[{reqId}] {exception_url} PHP Warning: array_merge(): Expected parameter 1 to be an array, null given8 of these in 1.43.0-wmf.27 (T375658). Spitballing some tags here.
For this reqId, also getting:
| Retrying connection to {elastic_host} after {attempts} attempts | 4 |
| Search backend error during updating {numBulk} documents after {tookMs}: {error_message} | 2 |
| Update weighted tag {weightedTagFieldName} for {weightedTagPrefix} in articles: {docIds} | 2 |
| [{reqId}] {exception_url} PHP Warning: array_merge(): Expected parameter 1 to be an array, null given | 2 |
| [{reqId}] {exception_url} PHP Warning: array_unique() expects parameter 1 to be array, null given | 2 |
| [{reqId}] {exception_url} PHP Warning: implode(): Invalid arguments passed | 2 |
| Inconsistent revision ID | 1 |
So maybe just fallout from a failure to connect.
No, this is new code we added to eswiki only to attempt to fix a certain issue. Seems like we created a new one! Putting onto our sprint and removing Discovery, as the cause is in Growth-maintained code.
If the volume of those errors get unbearable, it is possible to disable our changes by setting GETempLinkRecommendationSwitchTagClearHook to false.
Not sure the root cause lies with GrowthExperiments, but maybe we triggered a code-path that wasn't executed like that before. This seems similar to (though distinct from) T376715: TypeError: Argument 3 passed to CirrusSearch\DataSender::sendWeightedTagsUpdate() must be of the type array, null given, called in /srv/mediawiki/php-1.43.0-wmf.25/extensions/CirrusSearch/includes/Job/ElasticaWrite.php on line that I'll boldly add Discovery-Search and CirrusSearch back. Even if our code is wrong, it would probably be good to have those extra eyes on it.
Actually the fix on T376715: TypeError: Argument 3 passed to CirrusSearch\DataSender::sendWeightedTagsUpdate() must be of the type array, null given, called in /srv/mediawiki/php-1.43.0-wmf.25/extensions/CirrusSearch/includes/Job/ElasticaWrite.php on line might trigger more of these errors, seems to me like a logic error in cirrus, will take a look today.
Change #1081374 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/CirrusSearch@master] Do not attempt to unfold tag info when logging failures
Change #1081374 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Do not attempt to unfold tag info when logging failures
Change #1131015 had a related patch set uploaded (by Bartosz Dziewoński; author: DCausse):
[mediawiki/extensions/CirrusSearch@REL1_43] Do not attempt to unfold tag info when logging failures
Change #1131015 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@REL1_43] Do not attempt to unfold tag info when logging failures