Page MenuHomePhabricator

Recent changes doesn't have space after target title and before the reason part
Closed, ResolvedPublicBUG REPORT

Assigned To
None
Authored By
Kizule
Oct 18 2024, 1:05 AM
Referenced Files
F57640568: 2024-10-24_14-43-19.png
Oct 24 2024, 9:55 PM
F57640566: 2024-10-24_14-42-36.png
Oct 24 2024, 9:55 PM
F57640564: 2024-10-24_14-44-51.png
Oct 24 2024, 9:55 PM
F57622908: image.png
Oct 18 2024, 1:14 AM
F57622903: image.png
Oct 18 2024, 1:12 AM
F57622891: image.png
Oct 18 2024, 1:05 AM
Tokens
"Like" token, awarded by Od1n.

Description

Steps to replicate the issue (include links if applicable):

  • Open Serbian Wikipedia's recent changes
  • Search for "Дневник брисања" (which is the deletion log in English)

What happens?:
There is no space after the target title of the deleted page.

EnglishSerbian
image.png (143×1 px, 46 KB)
image.png (307×1 px, 93 KB)

What should have happened instead?:
There should be space as before.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Serbian Wikipedia (group 2)

Other information (browser name/version, screenshots, etc.):
This started happening today, it looks like after the deployment of MW for the group2 (T375658).

Derived Requirement

Ensure that there is a space after the target title and before the reason part in the recent changes deletion log on Serbian Wikipedia's "Дневник брисања" (deletion log).

BDD

gherkin
Feature: Space after target title in recent changes deletion log

Scenario: Ensure space is present after the target title and before the reason in the deletion log
  Given the user is viewing the recent changes page on Serbian Wikipedia
  And the user searches for "Дневник брисања" (deletion log)
  When the user views the deletion log entries
  Then there should be a space after the target title of the deleted page and before the reason part

Test Result - Beta|Prod

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: beta/srwiki
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Space Is Present After Target Title in Deletion Log

  1. Navigate to Serbian Wikipedia's recent changes page.
  2. Search for "Дневник брисања" (deletion log).
  3. Observe a log entry for a deleted page.
  4. ✅❓❌⬜ AC1: Confirm that there is a space after the target title of the deleted page and before the reason part in the log entry.

QA Results - Beta

ACStatusDetails
1T377533#10261025

QA Results - PROD

ACStatusDetails
1T377533#10261025

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Kizule renamed this task from Recent changes doesn't have space after target title to Recent changes doesn't have space after target title, just for deletions.Oct 18 2024, 1:05 AM
Kizule updated the task description. (Show Details)

Uh, oh, it looks like this is happening for nearly all logs.

Screenshot from English Wikipedia:

image.png (787×1 px, 260 KB)

Kizule renamed this task from Recent changes doesn't have space after target title, just for deletions to Recent changes doesn't have space after target title and before the reason part.Oct 18 2024, 1:17 AM
Pikne subscribed.

Seems related to recent actions taken in T376814.

Change #1081920 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Add back space before comment in deletion log

https://gerrit.wikimedia.org/r/1081920

Change #1081920 merged by jenkins-bot:

[mediawiki/core@master] Add back space before comment in log entries

https://gerrit.wikimedia.org/r/1081920

Ebrahim claimed this task.
Ebrahim subscribed.

Fix will be on the next deployment.

Thanks to @Ebrahim , @Lucas_Werkmeister_WMDE , and all the other good people who helped to report and fix it! ❤️

Test Result - Beta|PROD

Status: ✅ PASS
Environment: Beta/PROD srwiki
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidepageedits=1&hidenewpages=1&hidecategorization=1&hidewikistories=1&hideWikibase=1&hidenewuserlog=1&limit=500&days=30&urlversion=2
https://sr.wikipedia.org/wiki/%D0%9F%D0%BE%D1%81%D0%B5%D0%B1%D0%BD%D0%BE:%D0%A1%D0%BA%D0%BE%D1%80%D0%B0%D1%88%D1%9A%D0%B5_%D0%B8%D0%B7%D0%BC%D0%B5%D0%BD%D0%B5?hidepageedits=1&hidenewpages=1&hidecategorization=1&hideWikibase=1&hidenewuserlog=1&limit=50&days=7&urlversion=2

Test Steps

Test Case 1: Ensure Space Is Present After Target Title in Deletion Log

  1. Navigate to Serbian Wikipedia's recent changes page.
  2. Search for "Дневник брисања" (deletion log).
  3. Observe a log entry for a deleted page.
  4. AC1: Confirm that there is a space after the target title of the deleted page and before the reason part in the log entry.
BetaPROD EN-SRPROD SR
2024-10-24_14-44-51.png (430×1 px, 99 KB)
2024-10-24_14-42-36.png (1×1 px, 337 KB)
2024-10-24_14-43-19.png (1×1 px, 359 KB)
GMikesell-WMF updated the task description. (Show Details)