Use SaveUserOptions hook to validate template favourites
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	KSiebert
	Oct 21 2024, 2:01 PM

Description

Use the SaveUserOptions hook to validate the favourites data before it's saved. The hook should

de-duplicate the array of favourites page_id values
validate the data and return an error if it's not valid
- list should contain at most 50 values
- list should only contain positive integer values

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hooks-SaveUserOptions: Validate template favorites	mediawiki/extensions/TemplateData	master	+258 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	None	T367428 [EPIC] Favoriting Templates
In Progress	None	T377186 [STORY] New widget to search and favourite templates
Resolved	TheresNoTime	T377729 Use SaveUserOptions hook to validate template favourites

Event Timeline

KSiebert created this task.Oct 21 2024, 2:01 PM

KSiebert mentioned this in T377186: [STORY] New widget to search and favourite templates.Oct 21 2024, 2:04 PM

Cparle renamed this task from Use SaveUserOptions hook to limit number of favourites and prevent duplicates to Use SaveUserOptions hook to validate template favourites.Oct 23 2024, 1:04 PM

Cparle removed a project: Story.

Cparle updated the task description. (Show Details)

Cparle moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.

Cparle edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.

Cparle mentioned this in T377940: [STORY] Add template to favourites.

Cparle mentioned this in T377460: Notify user if they try to favourite a template when they already have the max number of favourites.Oct 23 2024, 1:06 PM

Samwilson mentioned this in T387187: Add functionality to favourite icon in search results.Feb 25 2025, 3:57 AM

TheresNoTime edited projects, added Community-Tech (Fox Squad); removed Community-Tech.Mar 3 2025, 1:24 PM

TheresNoTime claimed this task.Mar 3 2025, 2:45 PM

TheresNoTime moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.Mar 3 2025, 3:23 PM

Change #1124131 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] Hooks-SaveUserOptions: Validate template favorites