Page MenuHomePhabricator

MMV should have an affordance for which image is being viewed in the article
Closed, ResolvedPublic

Description

Background

When viewing an article, the media viewer allows you to page through the images in an article. After the change in T77877 this loops to the start of the article.

User story

As a reader, I want to know how many images are in page and the order they appear in the article.

Requirements

  • An affordance shows in the top right detailing how many images are in the page and the position of the currently viewed image.
  • When there is only one image in the article it shows 1/1
  • Images that do not appear in the page cannot be displayed. A notification shows when this happens.
  • The numbers are localized based on the language. For example in Farsi 2 / 2 is ۲ / ۲
  • It should be possible for editors via a gadget or Special:MyPage/common.css to hide the start and end arrows - there should be a class that identifies arrows in the loop state e.g. mw-mmv-prev-image-loop

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

arrows.jpg (881×1 px, 960 KB)

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1082268 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] MMV should have an affordance for which image is being viewed in the article

https://gerrit.wikimedia.org/r/1082268

Looks reasonable to me! I think the numbers can be a regular weight (they look bold?) and I was thinking we don't have to show the indicators if there is only one image but don't feel super strongly about it.

Jdlrobson triaged this task as Medium priority.Oct 23 2024, 8:30 PM

Change #1082268 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] MMV should have an affordance for which image is being viewed in the article

https://gerrit.wikimedia.org/r/1082268

Leaving open as the last 2 A/C are not addressed.

Change #1084202 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] MMV should have an affordance for which image is being viewed in the article (i18n)

https://gerrit.wikimedia.org/r/1084202

Change #1085626 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] It should be possible for editors via a gadget or Special:MyPage/common.css to hide the start and end arrows

https://gerrit.wikimedia.org/r/1085626

Change #1084202 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] MMV should have an affordance for which image is being viewed in the article (i18n)

https://gerrit.wikimedia.org/r/1084202

Change #1085626 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] It should be possible for editors via a gadget or Special:MyPage/common.css to hide the start and end arrows

https://gerrit.wikimedia.org/r/1085626

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

Thanks again @simon04 for continuing to evolve MMV!