Page MenuHomePhabricator

Cleanup "Move wikidata item link into Other Projects sidebar"
Closed, ResolvedPublic

Description

Scheduled for: 22nd November (1 month post release of T66315)

We have allowed 1 month post global rollout of the main "Move wikidata item link into Other Projects sidebar" ticket to hear about any bugs, improvements or opt-out requests from specific wikis. If, after this time, none have appeared, we can remove some of the auxilliary work from our code. This includes:

in wikibase repo

  • Remove module wikibase.sidebar.tracking and all references to it
  • Remove SidebarHookHandlerTest::testOnSidebarBeforeOutput and its data provider
  • Remove all references to moveConnectedItemLinkToOtherProjects flag
  • Remove SidebarHookHandlerTest::testMoveConnectedItemFeatureFlag_inActive
  • Consolidate testMoveConnectedItemFeatureFlag_active and getOnSidebarBeforeOutputResult in SidebarHookHandlerTest.php

Potentially we may be able to simplify some other logic in the SidebarHookHandler or its tests, but none have been currently identified.

in mediawiki-config repo

  • Remove all references to moveConnectedItemLinkToOtherProjects flag

This should be released after the Wikibase changes, so we should use the Depends-On tag

Misc

  • Remind team to also remove moveConnectedItemLinkToOtherProjects flag from their local settings once the changes are active
  • Remove dashboards, charts, and datasets built on wikibase_client_interaction from superset

Event Timeline

Change #1098042 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/extensions/Wikibase@master] Cleanup feature flag and tracking for wikibase item link location

https://gerrit.wikimedia.org/r/1098042

Change #1098045 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[operations/mediawiki-config@master] Remove feature flag which controls wikibase item link location

https://gerrit.wikimedia.org/r/1098045

Change #1098042 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Cleanup feature flag and tracking for wikibase item link location

https://gerrit.wikimedia.org/r/1098042

This ticket cannot be closed until we have removed data concerning wikidata sidebar link clicks from superset, therefore waiting for the go ahead from @Ifeatu_Nnaobi_WMDE

Hi Jo, you can go ahead and remove the charts from Superset. Thank you

Change #1098045 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove feature flag which controls wikibase item link location

https://gerrit.wikimedia.org/r/1098045

Mentioned in SAL (#wikimedia-operations) [2024-12-11T14:05:39Z] <samtar@deploy2002> Started scap sync-world: Backport for [[gerrit:1098045|Remove feature flag which controls wikibase item link location (T377809)]]

Mentioned in SAL (#wikimedia-operations) [2024-12-11T14:09:26Z] <samtar@deploy2002> samtar, joelyrookewmde: Backport for [[gerrit:1098045|Remove feature flag which controls wikibase item link location (T377809)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-12-11T14:18:11Z] <samtar@deploy2002> Finished scap sync-world: Backport for [[gerrit:1098045|Remove feature flag which controls wikibase item link location (T377809)]] (duration: 12m 32s)