Page MenuHomePhabricator

MPIC: UI improvements for the catalog table
Closed, ResolvedPublic3 Estimated Story Points

Description

Description

Some improvements/issues related to the Catalog table:

  • Sorting of “start date” column doesn’t work → Reach out to DST?
  • The “Actions” column header text should be bold
  • The “Actions” menu appears partially cut in tables with fewer entries because Codex Table only displays menus within the visible table area (2nd AC in this DST task wasn’t scoped T369934: [Timebox] MenuButton gets cut off in a table). At this time we fixed it with a workaround that DST suggested us while waiting for a fix through a new ticket we created T379947: MenuButton visually cropped in table with few rows
  • The first column header has a ‘max-width’ applied to it that causes it to misalign in width with the column’s content
  • How might we prevent the Table from increasing the width of the page’s content when the artifact names are too long? Apply max-width to the table or that column?

Acceptance Criteria

  • Sorting by start date works properly
  • "Actions" column header text is bold
  • Should we wait for DST to include the missing AC in T379947: MenuButton visually cropped in table with few rows to fix definitively the issue that prevents users from seeing the action menu when only a few entries are available in the Catalog table?
  • The first column header ("Name") is aligned with its column's content
  • Table doesn't increase the page width when name are too long

Event Timeline

Sfaci renamed this task from MPIC: Catalog table improvements to MPIC: UI improvements for the catalog table.Oct 22 2024, 11:20 AM
Sfaci set the point value for this task to 3.
Milimetric triaged this task as Medium priority.Nov 15 2024, 3:49 PM
Milimetric moved this task from BACKLOG to MPIC Alpha Scope on the Test Kitchen board.

I have updated description and the third AC (partial visibility of the action menu in the catalog view) to include the last improvement we did in the Action Menu. At this time there is a workaround that fixes that and a new ticket for DST to fix it.

  • The first column header ("Name") is aligned with its column's content
  • Table doesn't increase the page width when name are too long

I'm not 100% sure which change (or changes) addressed these issues but they are addressed on main:

T377826.png (2×3 px, 1 MB)

phuedx added a subscriber: Sarai-WMF.
  • "Actions" column header text is bold

@Sarai-WMF: I DM'd you about this but it's probably best that we discuss it here. As you can see in the screenshot above, all of the headers in the table are normal font weight. Should I change them all to bold?

Being bold and moving this to Needs Review for preliminary review while waiting for feedback from @Sarai-WMF.

  • "Actions" column header text is bold

@Sarai-WMF confirmed that all of the headers should be bold.

Works for me locally.

Thanks @Sfaci for getting the merge in - got the environment working this morning. I see the patch simplified itself, nice @phuedx.

Screenshot from 2024-12-12 06-27-00.png (1×1 px, 185 KB)

Change #1105431 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging

https://gerrit.wikimedia.org/r/1105431

Change #1105433 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production

https://gerrit.wikimedia.org/r/1105433

Change #1105431 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging

https://gerrit.wikimedia.org/r/1105431

Change #1105433 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production

https://gerrit.wikimedia.org/r/1105433