Page MenuHomePhabricator

WikiLambda: Provide a special page listing Functions with passing but unconnected tests
Closed, ResolvedPublic

Description

Description

To encourage and facilitate contributions to Wikifunctions content, we want to bring to light opportunities for community members to get engaged with relatively small contributions (which can also be learning experiences), such as checking the quality of currently-unconnected, but passing, tests, and then connecting them.

  • This special page will provide a list of functions that have currently-unconnected, but passing, tests.
  • It will also provide a brief description of how to check the quality of those tests and then connect them.

Some of the information can be obtained by querying WikiLambda's wikilambda_zobject_function_join DB table.

Desired behavior/Acceptance criteria

  • Results should be displayed cleanly and readably, and easy to understand.
  • Results should be retrieved and presented quickly, with minimal lag time and minimal burden on processing nodes, utilizing paging if needed.

Completion checklist

Details

Event Timeline

Change #1091791 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add Special page ListFunctionsByTests

https://gerrit.wikimedia.org/r/1091791

In the future, I think this page should also have unconnected implementations that pass a certain percentage of connected tests.

Change #1091791 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add Special page ListFunctionsByTests

https://gerrit.wikimedia.org/r/1091791

I have a few questions about the messages that are added here.

The message wikilambda-special-functionsbytests-summary says: "Find all Functions that have less than 2 connected tests: <code>Upper limit: 2</code>, <code>Test connection status: Connected</code>"

I assume, although I'm not sure, that "Test connection status:" refers to wikilambda-special-functionsbytests-form-status. But there's no message that specifically says "Upper limit". The closest one is wikilambda-special-functionsbytests-form-max, but it's "Upper limit of matching tests". Is there a reason that it's not the same as the text in wikilambda-special-functionsbytests-summary?

Also, why are they quoted in <code> tags? Do they appear as code or user input in a text box? Or is it just a form label or a help text? If it's the latter, just put them in quotes.

@Amire80

"Upper limit: 2" corresponds to the form field below named as "Upper limit of matching tests". There is no significant reason for it not to be exactly the same, I will make a note to make it identical.

As to why are they in <code>, it's just to highlight them as exact values to introduce in the fields.

Would it be clearer to express it more literally? Something like this:

To find all Functions that have less than 2 connected tests set "Upper limit of matching tests" to 2 and "Test connection status" to "Connected".

I have a few questions about the messages that are added here.

The message wikilambda-special-functionsbytests-summary says: "Find all Functions that have less than 2 connected tests: <code>Upper limit: 2</code>, <code>Test connection status: Connected</code>"

I assume, although I'm not sure, that "Test connection status:" refers to wikilambda-special-functionsbytests-form-status. But there's no message that specifically says "Upper limit". The closest one is wikilambda-special-functionsbytests-form-max, but it's "Upper limit of matching tests". Is there a reason that it's not the same as the text in wikilambda-special-functionsbytests-summary?

Also, why are they quoted in <code> tags? Do they appear as code or user input in a text box? Or is it just a form label or a help text? If it's the latter, just put them in quotes.

Yes, after translating it completely and trying it in production, I think that it's enough. Thanks.