Page MenuHomePhabricator

[SUL3] Make the `usesul3=0` query parameter work as the inverse of `usesul3=1`
Closed, ResolvedPublic

Description

We currently have a way to trigger SUL3 flow via a query parameter usesul3=1 but we don't have the inverse (with the flag). The inverse would be to just ignore the query param but we don't want sending usesul3=0 to do anything suspicious/unexpected in cases like central autologin etc.

So we need to implement usesul3=0 and make it do the expected thing we need across the CentralAuth codebase.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DAlangi_WMF changed the task status from Open to In Progress.Oct 23 2024, 8:51 AM
DAlangi_WMF moved this task from Backlog to In progress on the SUL3 board.

Change #1082425 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] SUL3: Disable SUL3 mode with `usesul3=0` query flag

https://gerrit.wikimedia.org/r/1082425

Change #1082425 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SUL3: Disable SUL3 mode with `usesul3=0` query flag

https://gerrit.wikimedia.org/r/1082425