Page MenuHomePhabricator

WikimediaEvents CI blocked with phan error
Closed, ResolvedPublic1 Estimated Story Points

Description

CI for MediaWiki-extensions-WikimediaEvents is currently blocked due to the following Phan error:

14:07:26 includes/SpecialWikimediaDebug.php:79 PhanTypeMismatchArgument Argument 1 ($data) is ['name'=>'renew','value'=>'1','label-message'=>['wikimediaevents-special-wikimediadebug-submit-renew',Message::durationParam(self::DEFAULT_EXPIRY)]] of type array{name:'renew',value:'1',label-message:array{0:'wikimediaevents-special-wikimediadebug-submit-renew',1:\JsonSerializable|\MediaWiki\Json\JsonDeserializable|\MediaWiki\Json\JsonDeserializableTrait|\MediaWiki\Json\JsonUnserializable|\MediaWiki\Json\JsonUnserializableTrait|\Wikimedia\Message\MessageParam|\Wikimedia\Message\ScalarParam}} but \MediaWiki\HTMLForm\HTMLForm::addButton() takes array{name:string,value:string,label-message?:\Wikimedia\Message\MessageSpecifier|array[]|string|string[],label?:string,label-raw?:string,id?:string,attribs?:array,flags?:string|string[],framed?:bool} defined at ../../includes/htmlform/HTMLForm.php:1304

Event Timeline

Change #1082471 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaEvents@master] Unblock CI

https://gerrit.wikimedia.org/r/1082471

Change #1082471 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Unblock CI

https://gerrit.wikimedia.org/r/1082471

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1082102 would also have fixed this problem (I +2'd it last night, but it failed to merge due to some unrelated error).

(comment mid-air collision)

Change #1084027 had a related patch set uploaded (by Kosta Harlan; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaEvents@wmf/1.43.0-wmf.28] Unblock CI

https://gerrit.wikimedia.org/r/1084027

Change #1084027 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.43.0-wmf.28] Unblock CI

https://gerrit.wikimedia.org/r/1084027

Mentioned in SAL (#wikimedia-operations) [2024-10-29T08:39:59Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1084027|Unblock CI (T377947)]], [[gerrit:1083967|StatsLib: Set label for wiki ID (T375496)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-29T08:45:14Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1084027|Unblock CI (T377947)]], [[gerrit:1083967|StatsLib: Set label for wiki ID (T375496)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-29T08:53:06Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1084027|Unblock CI (T377947)]], [[gerrit:1083967|StatsLib: Set label for wiki ID (T375496)]] (duration: 13m 06s)