| Cparle | |
| Oct 23 2024, 1:14 PM |
| F65721409: error_search_menu_reopen.webm | |
| Aug 7 2025, 9:20 AM |
| F65721392: error_unfavourite_twice.png | |
| Aug 7 2025, 9:20 AM |
| F65721380: error_loading_state.png | |
| Aug 7 2025, 9:20 AM |
| F59374730: two_notifications.webm | |
| Apr 24 2025, 7:55 AM |
While saving favourite templates using api.php?action=options an error might be returned.
Handle the error and inform the user via bubble notification similar to T377466: Show bubble notification after adding favourite
Change #1124575 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Handle errors when trying to save favourite templates
Change #1124575 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Handle errors when trying to save favourite templates
@Samwilson I find that when the API returns an error when favouriting/unfavouriting, I get two notifications: one saying there was an error and one saying it succeeded. The icon is also filled in, even if the favouriting was not successful. Similar thing happens when unfavouriting.
In the below example, I have set $wgReadOnly = true. Also note that I first try to favourite "DZA" but nothing happens. I believe because the API returned the error in HTML format. I am not sure why it did this or whether this is a common problem.
Change #1138944 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Fix rejected 'save' promise handling
Change #1138944 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Fix rejected 'save' promise handling
Testing on enwiki beta by logging out in another tab, I am seeing a couple more ways in which errors are not being handled gracefully:
Change #1176808 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Pop pending state of favorite button on failure to set pref
Change #1177584 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Don't modify favorites array until after saving
After an error, the favourite icon still has a loading state.
Patch for this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/1176808
If you click a filled in favourite icon twice it goes to the unfavourited state.
That might be what we want; I'm not sure. If you click, and then it's in pending state, and you click again, should it ignore your click or reverse it? If you click three times should it fave-unfave-fave? Or should further clicks have no effect until the pending state has stopped?
After clicking the favourite icon in the search dropdown, if you close and reopen the dropdown the icon will have changed.
Oops! That's bad. Patch for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/1177584
Each time you click a favourite icon it adds the new ID to the templatedata-favorite-templates variable in the action=options API request.
Also fixed by the above patch.
Change #1177584 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Don't modify favorites array until after saving
Change #1176808 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Pop pending state of favorite button on failure to set pref