Page MenuHomePhabricator
Create Task
Maniphest T377951

Display list of favourites
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
Samwilson
Authored By
Cparle
Oct 23 2024, 1:26 PM
Tags
Referenced Files
F60364406: image.png
May 22 2025, 2:48 AM
F60364400: image.png
May 22 2025, 2:48 AM
F58908838: image.png
Mar 24 2025, 11:02 AM
F58893018: image (1).png
Mar 22 2025, 1:01 AM
F58824051: Screenshot from 2025-03-14 14-25-11.png
Mar 14 2025, 6:26 AM
F58823965: image.png
Mar 14 2025, 6:26 AM
Subscribers
AAlhazwani-WMF
Aklapper
Cparle
JSengupta-WMF

Description

In the tab under the search widget show a list of favourites

  • when the tab loads use api.php?action=query&pageids=<pipe_separated_pages_id_of_favourite_templates> to get the page_title values for the templates
  • display the page titles in a list in alphabetical order, with a "selected" favourite icon beside each
  • show a scrollbar if necessary (or if this is difficult let's set the max number of templates to a smaller number)
  • if there are no favourites display a "you currently have no favourite templates" message

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Favorite templates: Hide or show the bookmark icon in the tab headermediawiki/extensions/TemplateDatamaster+28 -9
Add message when favorites list is emptymediawiki/extensions/TemplateDatamaster+35 -2
Sort templates by titlemediawiki/extensions/TemplateDatamaster+2 -1
Favorites: Rename SearchResult to TemplateMenuItemmediawiki/extensions/TemplateDatamaster+16 -16
Add template list below the template search inputmediawiki/extensions/TemplateDatamaster+111 -4
Favorites: Remove unused favorite config varmediawiki/extensions/TemplateDatamaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cparle created this task.Oct 23 2024, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2024, 1:26 PM
Cparle moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.Oct 23 2024, 1:27 PM
Cparle edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.
Cparle updated the task description. (Show Details)
Cparle updated the task description. (Show Details)Oct 23 2024, 1:30 PM
Cparle updated the task description. (Show Details)
Cparle updated the task description. (Show Details)Oct 23 2024, 3:03 PM
Cparle mentioned this in T377190: [STORY] Favourite templates displayed under search box.Oct 23 2024, 3:07 PM
Samwilson added a parent task: T377190: [STORY] Favourite templates displayed under search box.Jan 30 2025, 11:34 AM
JSengupta-WMF set the point value for this task to 5.Jan 30 2025, 11:45 AM
Samwilson claimed this task.Mar 13 2025, 1:03 AM
Samwilson edited projects, added Community-Tech (Fox Squad); removed Community-Tech.
Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.
gerritbot added a comment.Mar 13 2025, 5:58 AM

Change #1127257 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] [WIP] Add template list below the template search input

https://gerrit.wikimedia.org/r/1127257

gerritbot added a project: Patch-For-Review.Mar 13 2025, 5:58 AM
Samwilson added a subscriber: JSengupta-WMF.Mar 14 2025, 6:26 AM

@JSengupta-WMF The default OOUI tab style is to have padding around the title and to align the contents with that. Do you want this to be overridden to match the designs?

Current WIP (TemplateWizard)Design (VisualEditor)
image.png (608×723 px, 42 KB)
Screenshot from 2025-03-14 14-25-11.png (805×910 px, 53 KB)
gerritbot added a comment.Mar 17 2025, 3:14 AM

Change #1128062 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Favorites: Remove unused favorite config var

https://gerrit.wikimedia.org/r/1128062

gerritbot added a comment.Mar 17 2025, 3:21 AM

Change #1128064 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Favorites: Rename SearchResult to TemplateMenuItem

https://gerrit.wikimedia.org/r/1128064

gerritbot added a comment.Mar 17 2025, 3:00 PM

Change #1128062 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Favorites: Remove unused favorite config var

https://gerrit.wikimedia.org/r/1128062

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 17 2025, 4:00 PM
gerritbot added a comment.Mar 18 2025, 1:16 PM

Change #1127257 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Add template list below the template search input

https://gerrit.wikimedia.org/r/1127257

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 18 2025, 3:14 PM
gerritbot added a comment.Mar 20 2025, 6:30 AM

Change #1129724 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Add message when favorites list is empty

https://gerrit.wikimedia.org/r/1129724

gerritbot added a comment.Mar 20 2025, 12:01 PM

Change #1128064 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Favorites: Rename SearchResult to TemplateMenuItem

https://gerrit.wikimedia.org/r/1128064

gerritbot added a comment.Mar 21 2025, 6:17 AM

Change #1130009 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Sort templates by title

https://gerrit.wikimedia.org/r/1130009

Samwilson added a comment.Mar 22 2025, 1:01 AM

Regarding the 'no current favorites' message, having the icon within the message is not a common thing to do for translatable messages. On Slick, Amin suggested moving the icon to the tab label:

image (1).png (468×1 px, 19 KB)

Does this sound okay?

AAlhazwani-WMF subscribed.EditedMar 24 2025, 11:02 AM

another consideration: we could hide the bookmark icon when favorited templates are present, as it may become redundant in those cases

image.png (722×2 px, 123 KB)

JSengupta-WMF added a comment.Mar 24 2025, 11:11 AM

Both sound good to me. @AAlhazwani-WMF wdyt about the padding that Sam asked earlier on March 14? Doesn't bother me either way but I'm generally not a fan of overrides unless necessary.

AAlhazwani-WMF added a comment.Mar 24 2025, 11:15 AM
In T377951#10667261, @JSengupta-WMF wrote:

Both sound good to me. @AAlhazwani-WMF wdyt about the padding that Sam asked earlier on March 14? Doesn't bother me either way but I'm generally not a fan of overrides unless necessary.

yeah, agreed! i don't think overrides are necessary

Samwilson added a comment.Mar 24 2025, 12:35 PM

Great, thanks both of you. I'll move the no-items icon into the tab header, and leave the padding as-is for now. I think removing the tab header icon when there are favorites makes sense, but we could perhaps do the first take without that and update it if needed (just to keep things simpler).

Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Mar 25 2025, 5:12 AM
gerritbot added a comment.Mar 25 2025, 11:57 AM

Change #1130009 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Sort templates by title

https://gerrit.wikimedia.org/r/1130009

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 25 2025, 12:00 PM
AAlhazwani-WMF added a project: Wikimedia-Design.Mar 25 2025, 3:17 PM
Maintenance_bot added a project: Design.Mar 25 2025, 3:29 PM
gerritbot added a comment.Mar 26 2025, 9:40 AM

Change #1129724 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Add message when favorites list is empty

https://gerrit.wikimedia.org/r/1129724

TheresNoTime moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Mar 26 2025, 9:57 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 10:31 AM
KSiebert changed the task status from Open to Stalled.Mar 27 2025, 10:38 AM
Samwilson changed the task status from Stalled to Open.May 14 2025, 8:05 AM

Do we still want to change this so that the bookmark icon is shown in the tab header only when there are no favorites, and then not shown if there are any?

(Unstalling, as we're no longer waiting on QA.)

Samwilson moved this task from QA to In Development on the Community-Tech (Fox Squad) board.May 21 2025, 12:10 PM

Yes, it sounds like we do want to do that. (Discussion was on WMF Slack.)

Samwilson added a comment.May 22 2025, 2:48 AM

Example of the new design:

With no favoritesWith favorites
image.png (140×405 px, 9 KB)
image.png (110×398 px, 8 KB)
gerritbot added a comment.May 22 2025, 3:23 AM

Change #1148995 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Favorite templates: Hide or show the bookmark icon in the tab header

https://gerrit.wikimedia.org/r/1148995

gerritbot added a project: Patch-For-Review.May 22 2025, 3:23 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.May 22 2025, 4:50 AM
gerritbot added a comment.May 22 2025, 11:28 PM

Change #1148995 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Favorite templates: Hide or show the bookmark icon in the tab header

https://gerrit.wikimedia.org/r/1148995

Maintenance_bot removed a project: Patch-For-Review.May 22 2025, 11:30 PM
Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.May 22 2025, 11:32 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 23 2025, 12:01 AM
Samwilson added a project: TemplateData.EditedJul 7 2025, 1:21 AM
Samwilson removed a parent task: T377190: [STORY] Favourite templates displayed under search box.

(Removing this from the project story because it doesn't look like it's going to be worked on in the current cycle of work, but the story itself is done.) Sorry, wrong task!

Samwilson added a parent task: T377190: [STORY] Favourite templates displayed under search box.Jul 7 2025, 1:26 AM
Maintenance_bot added a project: VisualEditor.Jul 7 2025, 1:29 AM
Samwilson closed this task as Resolved.Jul 7 2025, 1:30 AM

The work for this is all done, and I think the feature is sufficiently covered by more specific open tasks to not need any extra QA here for the general usage.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits