Page MenuHomePhabricator
Create Task
Maniphest T377976

Remove feature flags
Open, Needs TriagePublic
Actions

Description

NOTE: Must be done first: T377975: Enable template favouriting on Beta, pilot wikis, and test and T391064: Enable template favoriting on all remaining WMF wikis

Removing the feature flag created in T377453:

  • $wgTemplateDataEnableDiscovery
  • $wgTemplateDataEnableCategoryBrowser
  • $wgTemplateDataEnableFeaturedTemplates

This will involved deleting the feature flags and all their conditionals everywhere in TemplateData, MediaWiki-extensions-TemplateWizard, and VisualEditor.

Note also that the module loading for VE will need to be moved from where it currently is in VE to the extension.json of TemplateData as a plugin module (example patch for that).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable cat browser and featured templates by defaultmediawiki/extensions/TemplateDatamaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cparle created this task.Oct 23 2024, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2024, 4:05 PM
Cparle moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.Oct 23 2024, 4:05 PM
Cparle edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.
Cparle mentioned this in T377978: [STORY] Template favouriting available on all foundation wikis.
Cparle renamed this task from Remove feature flags to Remove feature flag.Oct 23 2024, 4:09 PM
DLynch subscribed.Apr 3 2025, 3:38 PM

This will include moving the plugin-module registration created via a hack in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1120698 into TemplateData's extension.json.

Samwilson updated the task description. (Show Details)Apr 4 2025, 1:55 AM
Samwilson added a parent task: T377978: [STORY] Template favouriting available on all foundation wikis.
Samwilson subscribed.Apr 4 2025, 1:57 AM
In T377976#10708918, @DLynch wrote:

This will include moving the plugin-module registration created via a hack in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1120698 into TemplateData's extension.json.

Good point. I've updated the description (and also split out prod deployment from this task; the feature flag should only be removed after the feature is enabled everywhere).

Samwilson renamed this task from Remove feature flag to Remove feature flags.Jul 2 2025, 9:33 AM
Samwilson updated the task description. (Show Details)
Samwilson mentioned this in T407950: Remove old template search form.Wed, Oct 22, 8:04 AM
gerritbot added a comment.Wed, Oct 22, 11:13 PM

Change #1198177 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Enable cat browser and featured templates by default

https://gerrit.wikimedia.org/r/1198177

gerritbot added a project: Patch-For-Review.Wed, Oct 22, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits