Page MenuHomePhabricator

Date/Time formats for Serbian language are incorrect
Closed, ResolvedPublic

Description

(see https://sr.wikipedia.org/wiki/Википедија:Трг/Техника#Формати_датума_у_подешавањима)

Currently, there are five formats set for the Serbian language in preferences. Most of them are incorrect.

There should be just these correct formats:

  1. hour:minute, day. month year.
  2. hour:minute, day. shorterMonth. year.
  3. hour:minute, day. numberMonth. year.

What needs to be done

Requires changes to $dateFormats variable in MessagesXX.php files related to Serbian language in MediaWiki core repository.

Details

Related Changes in Gerrit:

Event Timeline

Also, the default is the correct one, so I guess in case this gets done, we'll be able to move users' preferences to the correct format just by dropping the date rows in the user_properties table.

  1. H:i, j. xg Y.
  2. H:i, j. M. Y.
  3. H:i, j. n. Y.

Or d. (d. m.) if you prefer zero padding for days and months.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Aklapper added a subscriber: ToluAyo.

@ToluAyo: This has no instructions or pointers how to fix the problem, thus removing good first task

Change #1171709 had a related patch set uploaded (by Kavaljeet Singh; author: Kavaljeet Singh):

[mediawiki/core@master] T378014: Set correct Serbian date formats (long, compact, numeric only)

https://gerrit.wikimedia.org/r/1171709

Patch submitted for review:[[ URL | https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1171709 ]]

Kindly review this fix for the Serbian date formats as discussed in the task.

Thank you!
— Kavaljeet Singh

Change #1171709 had a related patch set uploaded (by Kavaljeet Singh; author: Kavaljeet Singh):

[mediawiki/core@master] T378014: Set correct Serbian date formats

https://gerrit.wikimedia.org/r/1171709

Patch has been updated and pushed to Gerrit for review:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1171709

Waiting for further feedback. Thanks!

Change #1172413 had a related patch set uploaded (by Kavaljeet Singh; author: Kavaljeet Singh):

[mediawiki/core@master] T378014: Fix strlen null warnings by making variables null-safe

https://gerrit.wikimedia.org/r/1172413

This looks much better now.
{F65719446}

Change #1171709 merged by jenkins-bot:

[mediawiki/core@master] Set correct formats for Serbian dates

https://gerrit.wikimedia.org/r/1171709

Change #1172413 abandoned by Umherirrender:

[mediawiki/core@master] T378014: Fix strlen null warnings by making variables null-safe

https://gerrit.wikimedia.org/r/1172413

Change #1172413 restored by Kavaljeet Singh:

[mediawiki/core@master] T378014: Fix strlen null warnings by making variables null-safe

https://gerrit.wikimedia.org/r/1172413

Change #1172413 abandoned by Kavaljeet Singh:

[mediawiki/core@master] T378014: Fix strlen null warnings by making variables null-safe

https://gerrit.wikimedia.org/r/1172413