Page MenuHomePhabricator

Gerrit email title truncation over eager
Closed, ResolvedPublic


E-mail title: [Gerrit] (bug 33564) transwiki import sometimes result in invalid tit... - change (mediawiki/core[master])

Change subject: (bug 33564) transwiki import sometimes result in invalid title

So truncation actually results in longer subject.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:17 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz35802.

Should be pretty easy to fix in ChangeSubject.vm. I'm testing it locally then will submit to gerrit for review.

If it works, I'll submit the fix upstream as well. Thanks for reporting this.

Submitted for us in gerrit change 13325.

Also submitted upstream.

Upstream revert comment: "The truncation failed when the subject length was 59, throwing StringIndexOutOfBoundsException and causing email formatting to abort with no message sent."

Curious if same problem happens in our applied downstream patch (Gerrit change #13325)?

I had reverted our custom patch out of caution.

New fix was accepted upstream in commit 9fe238ec19d1ef5b16193b524e9b07cd031de46b

Submitted downstream patch for us in 05ae70be072d95721572ceeb5d2a92751f5a81c6