Page MenuHomePhabricator

poll creation and poll editing should be logged to Special:Log
Closed, InvalidPublicFeature

Description

Why

  • make it easy to figure out who created a poll
  • transparency
  • make SecurePoll logging more similar to our other types of logging

What

  • create a new Special:Log type called "SecurePoll log" or "Poll log" or "Election log" or similar, and log the following types of events to it:
    • poll creation
    • poll editing
  • log this all the time, even if $wgSecurePollUseLogging = false

Notes

  • not currently logged directly anywhere
  • is indirectly logged to Special:SecurePollLog if $wgSecurePollUseLogging = true and you're an electionadmin and you look up when the first electionadmin was added to the poll

Event Timeline

Doesn't it already make edits to the SecurePoll namespace? Why is that not sufficient?

My use case is I couldn't figure out who made https://en.wikipedia.org/wiki/Special:SecurePoll/vote/812.

This ticket is about someone not very familiar with SecurePoll being able to look in a standard place to find basic information about what's going on with the extension.

Does enwiki even have a SecurePoll namespace?

https://en.wikipedia.org/wiki/Template:Namespaces

https://en.wikipedia.org/wiki/SecurePoll:812 doesn't work for me.

(With the caveat that I'm not very familiar with SecurePoll)

From reading the code, nobody took any action on enwiki to create that - https://github.com/wikimedia/mediawiki-extensions-SecurePoll/blob/62bb30604ef36c3b8b95f738fe5105bd5a99115a/includes/Pages/CreatePage.php#L834 creates it automatically when the corresponding poll on VoteWiki was created.

The creation of the poll on VoteWiki is logged: https://vote.wikimedia.org/w/index.php?title=SecurePoll:1691&action=history

I think if we set up local elections then none of the cross-wiki code will get activated, enwiki will have to have a SecurePoll namespace created, and the logging will make more sense.

Perhaps this task should be repurposed to say that creating a poll should be logged on the "jump wikis" in addition to the main wiki, but I don't think that's necessary either.

Likewise I can make changes to the interwiki map by editing https://meta.wikimedia.org/w/index.php?title=Interwiki_map/list&action=history (and then a deploy happening) which is only logged on Meta and Gerrit, global abuse filter changes are only logged on Meta not on every wiki with global abuse filters enabled, global rights changes are only logged on Meta (but there's a task to fix this) etc.

https://vote.wikimedia.org/w/index.php?title=SecurePoll:1691&action=history looks good for logging. That's good enough. Thanks for that link. Will probably close this ticket as invalid and make some different tickets.

My ideas for the different tickets are:

  1. Add a Special:PrefixIndex link such as https://vote.wikimedia.org/wiki/Special:PrefixIndex/SecurePoll:1436 to the list of polls at Special:SecurePoll, so it's easier to find.
  1. On Wikis with these "jump" polls as you call them, we can have some kind of indicator that it's a "jump" poll, with a link back to the main vote.wikimedia.org poll, included on the Special:SecurePoll page.

Think these are decent ideas? If so I'll go create some tickets.

Both of those are reasonable to me.

I would also add to the second task to either not show or fix the dysfunctional "translate" and "list" links at https://en.wikipedia.org/wiki/Special:SecurePoll, which currently point to an error page saying just to use votewiki instead.

The second ticket would also help a little with T266385

I looked at the code more closely and it turns out the namespace is not canonical data like I expected - it's an optional configuration setting added in T73695.

I still think using a namespace is a better way of logging things then Special:Log here given the complexity of the data being stored.

optional configuration setting

I notice this repo has some optional configuration settings that may be good to turn on by default to simplify and standardize things. We should keep an eye out for opportunities to do this as we get more familiar with the repo.

For the two ideas mentioned above, I filed T378294: In Special:SecurePoll, add a link to search for pages for that poll in the SecurePoll namespace and T378293: In Special:SecurePoll, redirect polls should be more obvious and have most links disabled

Thanks for helping me talk this stuff out.