Page MenuHomePhabricator
Create Task
Maniphest T378302

Deprecated: str_getcsv(): the $escape parameter must be provided as its default value will change in DenyListManager.php on line 346
Closed, ResolvedPublic
Actions

Description

https://php.watch/versions/8.4/releases/8.4.0beta1

Passing a non-empty string for the $escape parameter of: - fputcsv() - fgetcsv() - str_getcsv() is now deprecated.
The str_getcsv() function now throws ValueErrors when the $separator and $enclosure arguments are not one byte long, or if the $escape is not one byte long or the empty string. This aligns the behaviour to be identical to that of fputcsv() and fgetcsv().

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Provide escape paramater for fgetcsvUmherirrendermediawiki/extensions/StopForumSpamREL1_43+1 -1
Provide escape paramater for fgetcsvUmherirrendermediawiki/extensions/StopForumSpamREL1_42+1 -1
Provide escape paramater for fgetcsvUmherirrendermediawiki/extensions/StopForumSpamREL1_39+1 -1
Provide escape paramater for fgetcsvUmherirrendermediawiki/extensions/StopForumSpammaster+1 -1
DenyListManager: Update str_getcsv() call for PHP 8.4Reedymediawiki/extensions/StopForumSpamREL1_41+1 -1
DenyListManager: Update str_getcsv() call for PHP 8.4Reedymediawiki/extensions/StopForumSpamREL1_43+1 -1
DenyListManager: Update str_getcsv() call for PHP 8.4Reedymediawiki/extensions/StopForumSpamREL1_42+1 -1
DenyListManager: Update str_getcsv() call for PHP 8.4Reedymediawiki/extensions/StopForumSpamREL1_39+1 -1
DenyListManager: Update str_getcsv() call for PHP 8.4Reedymediawiki/extensions/StopForumSpammaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 27 2024, 8:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2024, 8:50 PM
Reedy updated the task description. (Show Details)Oct 27 2024, 8:51 PM
gerritbot added a comment.Oct 27 2024, 8:53 PM

Change #1083463 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@master] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083463

gerritbot added a project: Patch-For-Review.Oct 27 2024, 8:53 PM
Reedy mentioned this in T378304: Deprecated: str_getcsv(): the $escape parameter must be provided as its default value will change.Oct 27 2024, 9:20 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.4 support board.Oct 27 2024, 9:23 PM
Reedy renamed this task from Deprecated: str_getcsv(): the $escape parameter must be provided as its default value will change in /var/www/wiki/mediawiki/extensions/StopForumSpam/includes/DenyListManager.php on line 346 to Deprecated: str_getcsv(): the $escape parameter must be provided as its default value will change in DenyListManager.php on line 346.Oct 27 2024, 9:53 PM
gerritbot added a comment.Oct 28 2024, 3:30 PM

Change #1083463 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083463

gerritbot added a comment.Oct 28 2024, 3:31 PM

Change #1083841 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@REL1_43] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083841

gerritbot added a comment.Oct 28 2024, 3:31 PM

Change #1083842 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@REL1_42] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083842

gerritbot added a comment.Oct 28 2024, 3:31 PM

Change #1083843 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@REL1_41] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083843

gerritbot added a comment.Oct 28 2024, 3:32 PM

Change #1083844 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/StopForumSpam@REL1_39] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083844

gerritbot added a comment.Oct 28 2024, 3:39 PM

Change #1083844 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_39] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083844

gerritbot added a comment.Oct 28 2024, 3:42 PM

Change #1083842 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_42] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083842

Reedy closed this task as Resolved.Oct 28 2024, 3:45 PM
Reedy claimed this task.
gerritbot added a comment.Oct 28 2024, 3:46 PM

Change #1083841 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_43] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083841

gerritbot added a comment.Oct 28 2024, 3:54 PM

Change #1083843 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_41] DenyListManager: Update str_getcsv() call for PHP 8.4

https://gerrit.wikimedia.org/r/1083843

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 28 2024, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2024, 4:30 PM
Lucas_Werkmeister_WMDE mentioned this in T386113: PHP 8.4: Wikibase CSVUnitStorage: fgetcsv(): the $escape parameter must be provided as its default value will change.Feb 11 2025, 4:14 PM
gerritbot added a comment.Feb 17 2025, 9:49 PM

Change #1120236 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StopForumSpam@master] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120236

gerritbot added a project: Patch-For-Review.Feb 17 2025, 9:49 PM
gerritbot added a comment.Feb 17 2025, 10:14 PM

Change #1120236 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120236

gerritbot added a comment.Feb 17 2025, 10:15 PM

Change #1120242 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StopForumSpam@REL1_43] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120242

gerritbot added a comment.Feb 17 2025, 10:15 PM

Change #1120243 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StopForumSpam@REL1_42] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120243

gerritbot added a comment.Feb 17 2025, 10:16 PM

Change #1120244 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StopForumSpam@REL1_39] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120244

gerritbot added a comment.Feb 17 2025, 10:27 PM

Change #1120244 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_39] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120244

gerritbot added a comment.Feb 17 2025, 10:37 PM

Change #1120243 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_42] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120243

gerritbot added a comment.Feb 17 2025, 10:39 PM

Change #1120242 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@REL1_43] Provide escape paramater for fgetcsv

https://gerrit.wikimedia.org/r/1120242

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18); removed: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Feb 17 2025, 11:00 PM
Reedy removed a project: Patch-For-Review.Apr 24 2026, 4:58 PM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptApr 24 2026, 4:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits