Page MenuHomePhabricator
Create Task
Maniphest T378322

TypeError: SecurePollContentHandler::makeContentFromElection(): Argument #1 ($election) must be of type Election, bool given (can't create elections on localhost if $wgSecurePollUseNamespace is turned on)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • on your localhost wiki...
$wgSecurePollUseNamespace = true;
  • make sure you are using 1 mariadb server, not 2
  • give yourself election admin
  • Visit Special:SecurePoll/create
  • Create a poll

What happens?:

  • PHP TypeError
[2437ea5fae22cb9cb5c640a8] /wiki/Special:SecurePoll/create TypeError: MediaWiki\Extension\SecurePoll\SecurePollContentHandler::makeContentFromElection(): Argument #1 ($election) must be of type MediaWiki\Extension\SecurePoll\Entities\Election, bool given, called in /var/www/html/w/extensions/SecurePoll/includes/Pages/CreatePage.php on line 914

Backtrace:

from /var/www/html/w/extensions/SecurePoll/includes/SecurePollContentHandler.php(161)
#0 /var/www/html/w/extensions/SecurePoll/includes/Pages/CreatePage.php(914): MediaWiki\Extension\SecurePoll\SecurePollContentHandler::makeContentFromElection()
#1 /var/www/html/w/extensions/SecurePoll/includes/Pages/CreatePage.php(893): MediaWiki\Extension\SecurePoll\Pages\CreatePage->recordElectionToNamespace()
#2 [internal function]: MediaWiki\Extension\SecurePoll\Pages\CreatePage->processInput()
#3 /var/www/html/w/includes/htmlform/HTMLForm.php(822): call_user_func()
#4 /var/www/html/w/includes/htmlform/HTMLForm.php(703): MediaWiki\HTMLForm\HTMLForm->trySubmit()
#5 /var/www/html/w/extensions/SecurePoll/includes/Pages/CreatePage.php(541): MediaWiki\HTMLForm\HTMLForm->tryAuthorizedSubmit()
#6 /var/www/html/w/extensions/SecurePoll/includes/SpecialSecurePoll.php(65): MediaWiki\Extension\SecurePoll\Pages\CreatePage->execute()
#7 /var/www/html/w/includes/specialpage/SpecialPage.php(728): MediaWiki\Extension\SecurePoll\SpecialSecurePoll->execute()
#8 /var/www/html/w/includes/specialpage/SpecialPageFactory.php(1726): MediaWiki\SpecialPage\SpecialPage->run()
#9 /var/www/html/w/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#10 /var/www/html/w/includes/actions/ActionEntryPoint.php(146): MediaWiki\Actions\ActionEntryPoint->performRequest()
#11 /var/www/html/w/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#12 /var/www/html/w/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#13 {main}

What should have happened instead?:

  • election is successfully created

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
remove setForcePrimary()mediawiki/extensions/SecurePollmaster+1 -21
CreatePageTest: Add test for log page creationmediawiki/extensions/SecurePollmaster+63 -6
Avoid db read-after-write contention while logging to namespacemediawiki/extensions/SecurePollmaster+37 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Oct 28 2024, 6:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2024, 6:42 AM
Novem_Linguae added a comment.Oct 29 2024, 7:42 AM

Right after creating a new election (I see the new election in my SQL database), this code path is reached:

		if ( $this->specialPage->getConfig()->get( 'SecurePollUseNamespace' ) ) {
			// Create a new context to bypass caching.
			$context = new Context;
			// We may be inside a transaction, so force a primary DB connection (T209804)
			$context->getStore()->setForcePrimary( true );

			$election = $context->getElection( $eId );

$wgSecurePollUseNamespace is true, so that conditional gets entered. An attempt is made to bypass the cache and to use a primary DB connection. Then an attempt is made to grab this election's data from cache. But $context->getElection( $eId ); returns false -- it is unable to grab the data.

Is there something going wrong with caching here?

Step debugging reveals this codepath:

image.png (532×1 px, 59 KB)

SD0001 subscribed.Oct 30 2024, 1:34 PM

I get the same error as well when $wgSecurePollUseNamespace is true. Using MariaDb in local.

Looks like the issue was previously seen in production and fixed with T209804 - which made it use the primary db. Surprising that it would occur on local where there is only one db.

gerritbot added a comment.Nov 18 2024, 5:33 PM

Change #1092298 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/SecurePoll@master] Avoid db read-after-write contention while logging to namespace

https://gerrit.wikimedia.org/r/1092298

gerritbot added a project: Patch-For-Review.Nov 18 2024, 5:33 PM
gerritbot added a comment.May 2 2025, 6:21 PM

Change #1140776 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/SecurePoll@master] remove setForcePrimary()

https://gerrit.wikimedia.org/r/1140776

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptMay 2 2025, 6:21 PM
Novem_Linguae renamed this task from TypeError: SecurePollContentHandler::makeContentFromElection(): Argument #1 ($election) must be of type Election, bool given to TypeError: SecurePollContentHandler::makeContentFromElection(): Argument #1 ($election) must be of type Election, bool given (can't create elections on localhost if $wgSecurePollUseNamespace is turned on).May 2 2025, 6:58 PM
Novem_Linguae updated the task description. (Show Details)
Novem_Linguae updated the task description. (Show Details)May 2 2025, 7:20 PM
gerritbot added a comment.May 2 2025, 7:58 PM

Change #1140781 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/SecurePoll@master] CreatePageTest: Add test for log page creation

https://gerrit.wikimedia.org/r/1140781

gerritbot added a comment.May 2 2025, 8:07 PM

Change #1092298 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Avoid db read-after-write contention while logging to namespace

https://gerrit.wikimedia.org/r/1092298

gerritbot added a comment.May 2 2025, 8:22 PM

Change #1140781 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] CreatePageTest: Add test for log page creation

https://gerrit.wikimedia.org/r/1140781

Novem_Linguae closed this task as Resolved.May 2 2025, 8:51 PM
Novem_Linguae assigned this task to SD0001.
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 2 2025, 9:00 PM
gerritbot added a comment.May 2 2025, 9:11 PM

Change #1140776 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] remove setForcePrimary()

https://gerrit.wikimedia.org/r/1140776

Maintenance_bot removed a project: Patch-For-Review.May 2 2025, 9:30 PM
Novem_Linguae added a project: Wikimedia-Hackathon-2025.May 3 2025, 9:57 AM
Novem_Linguae mentioned this in T395921: Investigate if some SecurePoll SQL tables can be merged.Jun 3 2025, 4:08 PM
SD0001 mentioned this in T320539: SecurePoll translations don't "stick" at the first save.Jun 12 2025, 8:18 PM
SD0001 added a parent task: T398897: Fix bugs related to writing JSON when $wgSecurePollUseNamespace = true.Jul 18 2025, 1:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits