Page MenuHomePhabricator
Create Task
Maniphest T378392

Show DiscussionTools empty state for existent talk pages when corresponding subject page does not yet exist
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show empty state message if subject doesn't exist but talk page existsmediawiki/extensions/DiscussionToolsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

ppelberg created this task.Oct 28 2024, 5:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2024, 5:47 PM
Esanders renamed this task from Show DiscussionTools empty state for created talk pages when corresponding anchor page does not yet exist to Show DiscussionTools empty state for existent talk pages when corresponding subject page does not yet exist.Oct 28 2024, 6:29 PM
Esanders subscribed.Oct 28 2024, 6:32 PM

The code comment which enforces this currently states: "Only if the subject page or the user exists (T288319, T312560)". The tasks there seem to be talking about when the talk page is non-existent.

gerritbot added a comment.Oct 29 2024, 12:46 PM

Change #1084099 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Show empty state message if subject doesn't exist but talk page exists

https://gerrit.wikimedia.org/r/1084099

gerritbot added a project: Patch-For-Review.Oct 29 2024, 12:46 PM
Esanders added a project: Editing-team (Kanban Board).Oct 29 2024, 12:46 PM
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
DLynch assigned this task to Esanders.Oct 29 2024, 2:44 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
DLynch added a project: Editing QA.
gerritbot added a comment.Oct 29 2024, 3:01 PM

Change #1084099 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Show empty state message if subject doesn't exist but talk page exists

https://gerrit.wikimedia.org/r/1084099

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2024, 3:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 29 2024, 4:00 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 13 2024, 4:05 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
Ryasmeen mentioned this in T376749: Run Flow migration script at *Phase 0* wikis.Nov 15 2024, 8:34 PM
VPuffetMichel closed this task as Resolved.Dec 16 2024, 9:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits