This would make a lot more sense if we move to the Revision table (T33858), since users could currently only do this filtering within the 30 day RecentChanges window.

We should wait until $wgNukeMaxAge has been increased before prioritising this - it's not so useful when there's only a 30-day window to filter within.

@OTichonova (with apologies for sending more tasks your way) could you quickly mock up adding start and end date selectors to Nuke?

I'm realising we may want to annotate $wgNukeMaxAge somewhere on the Nuke view too, since its value is specifically relevant here.

In T378493#10352986, @Samwalton9-WMF wrote:

We should wait until $wgNukeMaxAge has been increased before prioritising this - it's not so useful when there's only a 30-day window to filter within.

I think we can disregard this previous idea, it's fine to get this in sooner.

Change #1104659 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):

[mediawiki/extensions/Nuke@master] Support filtering by page creation date

https://gerrit.wikimedia.org/r/1104659

Is the validation warning appearing below the "from" and "to" dates a hard requirement? It'd be easier to show the warnings as part of the boxes as seen in T380297, but I understand if this isn't something that we should go for.

Minor note that since the Special:Nuke form currently doesn't use HTMLForm in its full capacity right now, trying to get anything validation-related to appear without having to duplicate code is a bit of an issue. I ran into this same issue trying to implement T380297. I'd love to spend some time trying to fix that, but that's some extra refactoring code, and it may not be as worth it when the Codex redesign is just around the corner.

In T378493#10406350, @Chlod wrote:

Is the validation warning appearing below the "from" and "to" dates a hard requirement? It'd be easier to show the warnings as part of the boxes as seen in T380297, but I understand if this isn't something that we should go for.

Hi @Chlod, that would work as well. It was originally in-line because the message pertains to the date itself.

Error message

Something I'm noticing with SpecialNuke.php is a great lack of expandability for the getNewPages function, whose signature keeps changing whenever we add new filters. It'd probably be a good idea to refactor it to take in a single filter object instead of multiple filter parameters, especially if there's plans (or not) to add more filters in the future. I'll probably do that work as part of the work to change up the form to use Codex (T153988).

Anyways, this should be ready for review soon. Just making some final polishes before sending to engineering review.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/2435fdf6ab/w/

Thanks for working on this, Chlod! I have a couple of comments UI-wise. While clicking around the UI, I noticed the error message when you input an incorrect date is not showing. I know it is not optimal to have duplicated code with Codex around the corner, but the validation messages are needed to provide context.

I also see that the From date field does not default to $today-$wgNukeMaxAge. This should be changed.

Further code review in the Gerrit CR.

It looks like the error message shows on the confirmation page, even if you didn't input an invalid date.

In T378493#10414431, @Scardenasmolinar wrote:

It looks like the error message shows on the confirmation page, even if you didn't input an invalid date.

Looks like this is coming from wpDeleteReasonList not having a default value. I've set it to default to "Other reason".

I've resolved some of the comments on the patch, and left other comments, but I'm still working on getting the field validation to display properly, as discussed in the check-in.

In T378493#10414430, @Scardenasmolinar wrote:

Thanks for working on this, Chlod! I have a couple of comments UI-wise. While clicking around the UI, I noticed the error message when you input an incorrect date is not showing. I know it is not optimal to have duplicated code with Codex around the corner, but the validation messages are needed to provide context.

Still looking for a way to get this done. Hoping to find out how by the end of this Friday but it's not looking likely, unfortunately, barring something really useful that I stumble upon.

In T378493#10414430, @Scardenasmolinar wrote:

I also see that the From date field does not default to $today-$wgNukeMaxAge. This should be changed.

Missed this from the task description. Fixed! Thanks for pointing it out.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/2435fdf6ab/w/

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/970c139b2e/w/

I've added in client-side validation for the date fields, which was more work than I expected, since HTMLForm doesn't seem to make it easy. This also means the error messages appear alongside the input, as originally designed. The downside is that it doesn't look that nice.

And it's particularly worse when both fields are invalid.

Maybe the message should be shortened? Or we could have these inputs be on their own lines instead, though arguably that also doesn't look that nice.

Noting here that the patch is ready for engineering review, but the issue above with the validation messages remains unresolved. Moving this to design review so that we know where this task is at the next meeting.

Also noting here that I've broken the patch for this task up into multiple patches: one for the validation message tests, another for adding in a context object to cut down on changing method signatures (see commit message of patch), another for a function that allows backdating page creations in tests, and the actual addition of the page creation filters. The rationale behind this is so that I can work on the Codex form with the new date filters and other helpful tests and utilities, without falling into merge conflict hell if this patch happens to get merged first, especially since feedback won't be rapid until the year turns over.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/970c139b2e/w/

Thanks @Chlod

Maybe the message should be shortened? Or we could have these inputs be on their own lines instead, though arguably that also doesn't look that nice.

I think keeping under each input is fine.
Makes sense to try to make it shorter. Maybe something like "Only pages created in the last 7 days can be deleted. Please change the date so it is within the range."

Thanks Olga! I've applied the new message in the latest patchset.

I have been playing around with the patch, and I can't trigger the error for the To Date field, even when I set a date way into the future.

I am seeing the same behavior in the Patch Demo I just created.

I have a question for @OTichonova: What do you think about adding a default date in the To Date field? I think it would look better if both date fields have defaults and it would also tell the user what the date limits are at a glance.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/e8af421dc6/w/

I didn't add a check to ensure that the "to date" goes far in the future as an application of Postel's law. The date filters for Special:Contributions also works the same way, allowing dates that are in the future (and even far in the past, but in our case we're restricting that date) rather than returning an error. In any case, no revisions will ever be dated in the future, so this will always return up to the current time (or for "from date", always return nothing).

If this is something that should throw a hard error, then I can also add that check in, but there may be UX implications (users trying to put in "just any date in the future so that it gets everything up until now" being met with an error instead of usable results).

Change #1104659 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Support filtering by page creation date

https://gerrit.wikimedia.org/r/1104659

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/e8af421dc6/w/

verified working on testwiki; leaving open until train rolls out