[M] Passing in numbers for V1 illustrations
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Oct 29 2024, 3:25 PM

Description

Background

We are updating the illustrations of the Year in Review feature to be gradients, with a number on top. These are for the V1 initial release, and may be further improved for V2.

Requirements

Pass in correct number for each slide according to the designs
For personalized editing illustration, show total articles read in illustration
- Display "500+" if users have more than 500 edits
For personalized reading illustration, show total number of articles read
Numbers should be localized (correct formatting for Device country)

Designs:

Figma

Engineering Notes

Related Objects
Search...

Status	Assigned	Task
Resolved	HNordeenWMF	T371946 [Epic] Wikipedia Year in Review on iOS App
Resolved	None	T376037 [Engineering Epic] Wikipedia Year in Review V1 Main Flow & Actions
Resolved	None	T377870 [XL] Add illustrations for V1 Year in Review
Resolved	None	T378508 [M] Passing in numbers for V1 illustrations

Event Timeline

HNordeenWMF created this task.Oct 29 2024, 3:25 PM

HNordeenWMF triaged this task as Medium priority.

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF mentioned this in T376037: [Engineering Epic] Wikipedia Year in Review V1 Main Flow & Actions.Oct 29 2024, 3:31 PM

HNordeenWMF mentioned this in T377870: [XL] Add illustrations for V1 Year in Review.Oct 29 2024, 3:33 PM

HNordeenWMF updated the task description. (Show Details)

Tsevener renamed this task from Passing in numbers for V1 illustrations to [M] Passing in numbers for V1 illustrations .Oct 29 2024, 6:21 PM

HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 29 2024, 9:24 PM

Seddon moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 30 2024, 1:57 PM

Seddon moved this task from Current Sprint Work to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Seddon set the point value for this task to 1.Oct 30 2024, 2:55 PM

Seddon changed the point value for this task from 1 to 3.

Tsevener assigned this task to GOlson-WMF.Oct 31 2024, 8:25 PM

@GOlson-WMF , @Tsevener if this is picked up after Nov 1 when Shay has pulled updated data, could this update numbers task be easily accomplished at the same time as this one? (and no longer needed )

GOlson-WMF moved this task from Ready for future sprints to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 1 2024, 2:50 PM

Tsevener removed GOlson-WMF as the assignee of this task.Nov 1 2024, 6:23 PM

Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener added a subscriber: GOlson-WMF.

@HNordeenWMF sorry missed your question. I believe this work was already done at the same time as T378491.

Looks good on 7.6.2 (4337)

It doesn't look like the update to November 1st data has been done yet - I have that in this task: T378515.

@GOlson-WMF the numbers on the gradients don't appear to be localizing - should they be? When I change Region to Italy, I still see 1,400,000,000 but I would expect to see 1.400.000.000). It's correct in the text (Showing 1,4 Billion for Italy instead of 1.4 Billion.

HNordeenWMF moved this task from Ready for PM Signoff to Did not pass QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 5 2024, 1:38 AM

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5055

GOlson-WMF moved this task from Did not pass QA to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 6 2024, 7:01 PM

GOlson-WMF updated Other Assignee, added: GOlson-WMF.

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5055