Page MenuHomePhabricator
Create Task
Maniphest T378573

Wikibase CI blocked by errors in SkinAfterPortletHandlerTest and ChangesListSpecialPageHookHandlerTest
Open, Needs TriagePublic
Actions

Description

Same exception in three cases, e.g.

09:19:57 1) Wikibase\Client\Tests\Unit\Hooks\ChangesListSpecialPageHookHandlerTest::testAddFilter
09:19:57 InvalidArgumentException: Invalid username: 
09:19:57 
09:19:57 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:255
09:19:57 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:230
09:19:57 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthIdLookup.php:114
09:19:57 /workspace/src/extensions/GlobalPreferences/includes/GlobalUserOptionsStore.php:75
09:19:57 /workspace/src/extensions/GlobalPreferences/includes/GlobalUserOptionsStore.php:35
09:19:57 /workspace/src/includes/user/Options/UserOptionsManager.php:494
09:19:57 /workspace/src/includes/user/Options/UserOptionsManager.php:570
09:19:57 /workspace/src/includes/user/Options/UserOptionsManager.php:460
09:19:57 /workspace/src/includes/user/Options/UserOptionsManager.php:169

Job logs: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/50360/console

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Set username in user mock and reset state after testmediawiki/extensions/WikibaseREL1_43+5 -1
Set username in user mock and reset state after testmediawiki/extensions/Wikibasewmf/1.43.0-wmf.28+5 -1
Set username in user mock and reset state after testmediawiki/extensions/Wikibasewmf/1.43.0-wmf.28+5 -1
Set username in user mock and reset state after testmediawiki/extensions/Wikibasewmf/1.44.0-wmf.1+5 -1
Set username in user mock and reset state after testmediawiki/extensions/Wikibasemaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Oct 30 2024, 8:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2024, 8:49 AM
Jakob_WMDE added a project: ci-test-error (WMF-deployed Build Failure).Oct 30 2024, 8:49 AM
WMDE-leszek subscribed.Oct 30 2024, 8:56 AM
gerritbot added a comment.Oct 30 2024, 9:41 AM

Change #1084718 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1084718

gerritbot added a project: Patch-For-Review.Oct 30 2024, 9:41 AM
Michael subscribed.Oct 30 2024, 10:07 AM
gerritbot added a comment.Oct 30 2024, 10:55 AM

Change #1084718 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1084718

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 30 2024, 11:00 AM
Aklapper added a project: MediaWiki-extensions-Wikibase-Client.Oct 30 2024, 11:17 AM
Maintenance_bot added a project: Wikidata.Oct 30 2024, 11:29 AM
Maintenance_bot removed a project: Patch-For-Review.
gerritbot added a comment.Oct 30 2024, 1:11 PM

Change #1084774 had a related patch set uploaded (by Sergio Gimeno; author: Arthur taylor):

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.1] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1084774

gerritbot added a project: Patch-For-Review.Oct 30 2024, 1:11 PM
gerritbot added a comment.Oct 30 2024, 8:28 PM

Change #1084774 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.1] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1084774

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2024, 8:30 PM
Stashbot added a comment.Oct 30 2024, 8:43 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-30T20:43:32Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1084774|Set username in user mock and reset state after test (T378573)]], [[gerrit:1084775|Fix and re-enable selenium test (T378581)]], [[gerrit:1084776|Fix selenium test loading the wrong talk page]], [[gerrit:1084185|build: Suppress phan issue with null for Message::numParams]], [[gerrit:1084181|HomepageHooks: do not store assigned variant on account cre

Stashbot mentioned this in T378581: Re-enable browser test in repo/tests/selenium/specs/item.js.Oct 30 2024, 8:43 PM
Stashbot added a comment.Oct 30 2024, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-30T20:45:53Z] <tgr@deploy2002> sgimeno, umherirrender, tgr: Backport for [[gerrit:1084774|Set username in user mock and reset state after test (T378573)]], [[gerrit:1084775|Fix and re-enable selenium test (T378581)]], [[gerrit:1084776|Fix selenium test loading the wrong talk page]], [[gerrit:1084185|build: Suppress phan issue with null for Message::numParams]], [[gerrit:1084181|HomepageHooks: do not store assigned variant on account

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.1; 2024-10-29); removed MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 30 2024, 9:00 PM
Stashbot added a comment.Oct 30 2024, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-30T21:01:51Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1084774|Set username in user mock and reset state after test (T378573)]], [[gerrit:1084775|Fix and re-enable selenium test (T378581)]], [[gerrit:1084776|Fix selenium test loading the wrong talk page]], [[gerrit:1084185|build: Suppress phan issue with null for Message::numParams]], [[gerrit:1084181|HomepageHooks: do not store assigned variant on account cr

gerritbot added a comment.Oct 31 2024, 9:58 AM

Change #1085339 had a related patch set uploaded (by Sergio Gimeno; author: Arthur taylor):

[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.28] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1085339

gerritbot added a project: Patch-For-Review.Oct 31 2024, 9:58 AM
gerritbot added a comment.Oct 31 2024, 10:02 AM

Change #1085342 had a related patch set uploaded (by Sergio Gimeno; author: Arthur taylor):

[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.28] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1085342

gerritbot added a comment.Oct 31 2024, 10:03 AM

Change #1085339 abandoned by Sergio Gimeno:

[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.28] Set username in user mock and reset state after test

Reason:

duplicate of 1085342

https://gerrit.wikimedia.org/r/1085339

ArthurTaylor mentioned this in T378688: Sanctions test suite failures in SanctionsPagerTest and SpecialIPContributionsTest.Oct 31 2024, 10:04 AM
gerritbot added a comment.Oct 31 2024, 1:22 PM

Change #1085342 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.28] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1085342

Stashbot added a comment.Oct 31 2024, 1:28 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-31T13:28:03Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1085342|Set username in user mock and reset state after test (T378573)]], [[gerrit:1085343|Fix and re-enable selenium test (T378581)]], [[gerrit:1085344|Fix selenium test loading the wrong talk page]], [[gerrit:1085346|HomepageHooks: do not store assigned variant on account creation (T377713)]], [[gerrit:1085347|SpecialHomepage: show community update

Stashbot mentioned this in T377713: Do not call ExperimentUserManager::setVariant on all newly registered accounts.Oct 31 2024, 1:28 PM
Stashbot added a comment.Oct 31 2024, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-31T13:30:36Z] <urbanecm@deploy2002> hnowlan, sgimeno, urbanecm: Backport for [[gerrit:1085342|Set username in user mock and reset state after test (T378573)]], [[gerrit:1085343|Fix and re-enable selenium test (T378581)]], [[gerrit:1085344|Fix selenium test loading the wrong talk page]], [[gerrit:1085346|HomepageHooks: do not store assigned variant on account creation (T377713)]], [[gerrit:1085347|SpecialHomepage: show community upda

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2024, 1:30 PM
Stashbot added a comment.Oct 31 2024, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-31T13:38:47Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1085342|Set username in user mock and reset state after test (T378573)]], [[gerrit:1085343|Fix and re-enable selenium test (T378581)]], [[gerrit:1085344|Fix selenium test loading the wrong talk page]], [[gerrit:1085346|HomepageHooks: do not store assigned variant on account creation (T377713)]], [[gerrit:1085347|SpecialHomepage: show community update

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 31 2024, 2:00 PM
gerritbot added a comment.Oct 31 2024, 5:01 PM

Change #1085440 had a related patch set uploaded (by Umherirrender; author: Arthur taylor):

[mediawiki/extensions/Wikibase@REL1_43] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1085440

gerritbot added a project: Patch-For-Review.Oct 31 2024, 5:01 PM
gerritbot added a comment.Oct 31 2024, 6:31 PM

Change #1085440 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_43] Set username in user mock and reset state after test

https://gerrit.wikimedia.org/r/1085440

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2024, 7:30 PM
Jdforrester-WMF subscribed.Dec 16 2024, 3:40 PM

Is there anything left to do here, or can this be declared Resolved?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits