Page MenuHomePhabricator

Contrast issues in StartEditing and SuggestedEdits modules
Closed, DuplicatePublic

Description

The modules displayed in the homepage have different background and text colors. The first version of many modules was created before Codex existed or it had a more complete color palette as it does now. This task is to review and consolidate the background and text colors which will ideally use a Codex color token rather than a custom Growth color. The task scoped to StartEditing and SuggestedEdits for similarity but this review should be done with all modules

Contrast issues on dark mode (no no-theme skin-invert applied)

Module/interfaceCurrent background colorDark mode/WCAG AA compliantProposed bg colorOutcome
Start editing, headerrgba(234, 243, 255, 0.5)
Screenshot 2024-10-30 at 13.12.08.png (1,888×784 px, 226 KB)
background-color-progressive-subtle
Screenshot 2024-10-30 at 13.36.20.png (1,232×1,322 px, 188 KB)
Suggested editsrgba(234, 243, 255, 0.5)
Screenshot 2024-10-30 at 13.44.23.png (1,832×1,844 px, 438 KB)
background-color-progressive-subtle
Screenshot 2024-10-30 at 13.44.23.png (1,832×1,844 px, 438 KB)

Open questions

  • What color tokens should we use for the task difficulty levels, so far:
ColorCurrentProposed
easyColor#14866d#099979 (border-color-success)
easyBackgroundColor#d5fdf4#dff2eb (background-color-success-subtle)
mediumColor#ac6600#ab7f2a (border-color-warning)
mediumBackgroundColor#fef6e7#fdf2d5 (background-color-warning-subtle)
hardColor#b32424#f54739 (border-color-error)
hardBackgroundColor#fee7e6#ffe9e5 (background-color-error-subtle)

Event Timeline

Sgs triaged this task as High priority.
Sgs moved this task from Inbox to Backlog on the Growth-Team board.

@JFernandez-WMF could you review the task description and propose some colors for the task difficulty levels or different text color for the EASY 3-5 minutes text under the suggested edits card. Thank you!

JFernandez-WMF updated the task description. (Show Details)

thanks @Sgs for creating this task! the proposed bg colors both for the header and the module look great to me.
I added a proposal for the difficulty tags — feel free to raise concerns/questions :)

Change #1090476 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: use Codex tokens for difficulty colors

https://gerrit.wikimedia.org/r/1090476

Change #1090485 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits/StartEditing: change custom background color to Codex token

https://gerrit.wikimedia.org/r/1090485

Change #1090486 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits/StartEditing: remove temporary dark-mode hack

https://gerrit.wikimedia.org/r/1090486

Change #1090476 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: use Codex tokens for difficulty colors

https://gerrit.wikimedia.org/r/1090476

Change #1090485 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits/StartEditing: change custom background color to Codex token

https://gerrit.wikimedia.org/r/1090485

Change #1090486 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits/StartEditing: remove temporary dark-mode hack

https://gerrit.wikimedia.org/r/1090486