"pairsfile" do not change the text
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vzhik227
	Oct 30 2024, 8:00 PM

Description

On Pywikibot version 7.7.0 everything works and there are no spaces. The problem is on versions 8+ and 9+.
I give the command python pwb.py replace -file:blah.txt -pairsfile:allwords.txt
it only changes the text in the wiki article where there are line breaks. (enter). That is, if in the article "a" and "b" are in a line, it will not change to "c" and "d", but if in the column
"a"
"b"
it will change.
The same computer, it is the same version of Python. Only different Pywikibot. 7.7.0 and 9.5.0.

log and screen

replace-bot.log85 KBDownload

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[test] Test replace.handle_pairs()	pywikibot/core	master	+38 -4
	[bugfix] strip newlines from pairsfile lines	pywikibot/core	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: rPWBC11d5f92c6fbb: [IMPR] use pathlib instead of codecs for replace.py

Event Timeline

Vzhik227 created this task.Oct 30 2024, 8:00 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 30 2024, 8:00 PM

I don't know if you need the file with the words{F57660675}

blah.txt54 BDownload

replacement. I'll attach it if you need it.

Xqt changed the task status from Open to In Progress.Oct 31 2024, 9:11 AM

Xqt claimed this task.

Xqt triaged this task as High priority.

In T378647#10278933, @Vzhik227 wrote:

I don't know if you need the file with the words{F57660675}

blah.txt54 BDownload
replacement. I'll attach it if you need it.

the allwords file would help.

Sorry, probably sent badly. Once again:

allwords.txt130 KBDownload

Thank you. Could you also publish the family file please.

Yes, sure{F57662926}

Just in case, the screen is on 7.7.0 and 9.5.0

screen-7.7.0.xt4 KBDownload

screen-9.5.0.xt1 KBDownload

Xqt added a project: Regression.Oct 31 2024, 9:55 AM

The regression was introduced with rPWBC11d5f92 in release 8.0.0 where splitlines() was replaced by readlines(). The later keeps the line feed \n for each tag of a line.

Do I need to somehow remake the file allwords.txt?

Change #1085351 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] strip newlines from pairsfile lines

https://gerrit.wikimedia.org/r/1085351

gerritbot added a project: Patch-For-Review.Oct 31 2024, 10:22 AM

In T378647#10280135, @Vzhik227 wrote:

Do I need to somehow remake the file allwords.txt?

No. There is a bug in handling pairsfile which is solved now with the patch above.

Checked the patch. It works! Excellent! Thank you very much!

Xqt closed this task as Resolved.Oct 31 2024, 11:16 AM

Change #1085351 merged by Xqt:

[pywikibot/core@master] [bugfix] strip newlines from pairsfile lines

https://gerrit.wikimedia.org/r/1085351

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2024, 12:30 PM

Change #1085374 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [test] Test replace.handle_pairs()

https://gerrit.wikimedia.org/r/1085374

gerritbot added a project: Patch-For-Review.Oct 31 2024, 12:55 PM

Change #1085374 merged by jenkins-bot: