- ALTERs to run:
- https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/ffc9fdf061b7902ed2c3e8416c17b2d9fbd7805b/sql/mysql/patch-global_block_whitelist-drop-gbw_target_central_id.sql
- https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/22e8eecc7cfbf01592bbc733b4bd41edc07dd7ed/sql/mysql/patch-global_block_whitelist-drop-gbw_address.sql
- Where to run those changes: all.dblist
- When to run those changes: When DBA has time - cleanup work that isn't blocking anything
- If the schema change is backwards compatible: Columns being dropped are no longer used anywhere
- If the schema change has been tested already on some of the test/beta wikis: Applied to the beta cluster
- If the data should be made available on the labs replicas and/or dumps: No changes to the current visibility of the global_block_whitelist table are needed
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Ladsgroup | T378747 Drop gbw_address and gbw_target_central_id from the global_block_whitelist table on WMF wikis | |||
| Resolved | taavi | T387663 Update views on global_block_whitelist tables |
Event Timeline
Comment Actions
Wiki Replicas weren’t updated, making the view there unusable. :( See https://quarry.wmcloud.org/query/91385: it says
View 'enwiki_p.global_block_whitelist' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
and if I remove the DESCRIBE command, I get the following query (reformatted for readability):
CREATE ALGORITHM=UNDEFINED DEFINER=`viewmaster`@`%` SQL SECURITY DEFINER VIEW `global_block_whitelist` AS SELECT `enwiki`.`global_block_whitelist`.`gbw_id` AS `gbw_id`, `enwiki`.`global_block_whitelist`.`gbw_address` AS `gbw_address`, -- this was dropped `enwiki`.`global_block_whitelist`.`gbw_by` AS `gbw_by`, `enwiki`.`global_block_whitelist`.`gbw_by_text` AS `gbw_by_text`, `enwiki`.`global_block_whitelist`.`gbw_reason` AS `gbw_reason`, `enwiki`.`global_block_whitelist`.`gbw_expiry` AS `gbw_expiry`, `enwiki`.`global_block_whitelist`.`gbw_target_central_id` AS `gbw_target_central_id` -- and so was this FROM `enwiki`.`global_block_whitelist`;
Please also update the views to drop the no longer existing columns.
Comment Actions
Thanks for the report - I have created T387663: Update views on global_block_whitelist tables so cloud-services-team can deal with it.