Page MenuHomePhabricator

General fixes: AWB not correctly combining duplicate references
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
AWB sometimes adds names to all the relevant references, as it should. However, on the second and subsequent duplicates, it 1) doesn't add the slash after the name and 2) it doesn't remove the reference content or the </ref>.

See https://simple.wikipedia.org/w/index.php?title=Ahwak_(Abu_song)&diff=prev&oldid=9857976 for example of such a change.

I say "sometimes" because in some articles AWB handled this correctly (see https://simple.wikipedia.org/w/index.php?title=Al-Hayat_Media_Center&diff=prev&oldid=9857992), and in some it didn't combine duplicates at all (such as https://simple.wikipedia.org/w/index.php?title=Air_Belgium_(2016)).

What should have happened instead?:
On the second and subsequent duplicate references, a slash should have been added after the reference name and the reference content and </ref> should have been removed. For example, the second and subsequent occurrences should have been changed like this:

before: <ref>reference content</ref>
after: <ref name="ref name"/>

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Here Rjwilmsi explained it:

It's because the first instance of the reference is used inside the infobox. As AWB can't tell from the source code of the page whether the infoxbox will render that parameter and hence the reference, AWB cannot safely condense later references. We had to have this restriction because of problems in the past.

OK, I'll do those manually and make sure they're working correctly before saving. Thanks for the explanation.

Rjwilmsi claimed this task.