Maniphest T378804

Special:Translate ignores optional=1 in the URL
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Nov 1 2024, 10:14 AM

Tags

Referenced Files

	F57666325: Screenshot 2024-11-01 at 11-11-58 Translate - translatewiki.net.png
	Nov 1 2024, 10:14 AM

	F57666323: Screenshot 2024-11-01 at 11-11-31 Translate - translatewiki.net.png
	Nov 1 2024, 10:14 AM

Subscribers

Description

Steps to reproduce

Open https://translatewiki.net/w/i.php?title=Special:Translate&group=out-osm-0-all&language=fr&filter=fuzzy&action=translate&optional=1.
After the page finished loading, look at the URL as well as the … → Optional messages checkbox.

Actual result

&optional=1 is gone from the URL, the checkbox is unchecked.

Expected result

&optional=1 is still in the URL, the checkbox is checked (and outdated optional messages are shown).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	fix(Special:Translate): Do not ignore optional=1 in URL	mediawiki/extensions/Translate	master	+7 -4

Customize query in gerrit

Event Timeline

Tacsipacsi created this task.Nov 1 2024, 10:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2024, 10:14 AM

Tacsipacsi claimed this task.Nov 1 2024, 10:14 AM

Change #1085571 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/extensions/Translate@master] fix(Special:Translate): Do not ignore optional=1 in URL

https://gerrit.wikimedia.org/r/1085571

gerritbot added a project: Patch-For-Review.Nov 1 2024, 10:19 AM

See https://translatewiki.net/wiki/Support#c-Tacsipacsi-20241031220500-Mahabarata-20241031174300, where this bug came up.

Change #1085571 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] fix(Special:Translate): Do not ignore optional=1 in URL

https://gerrit.wikimedia.org/r/1085571

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2024, 1:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Nov 4 2024, 2:00 PM

Nikerabbit added projects: LPL Essential (LPL Essential 2024 Jul-Oct), Unplanned-Sprint-Work.Nov 4 2024, 4:23 PM

Nikerabbit set the point value for this task to 1.

Nikerabbit moved this task from Sprint Backlog to Pending Deployment on the LPL Essential (LPL Essential 2024 Jul-Oct) board.

abi_ triaged this task as Medium priority.Nov 5 2024, 6:19 AM

Works well. Tested on translatewiki.net: https://translatewiki.net/w/i.php?title=Special:Translate&group=out-osm-0-all&language=fr&filter=fuzzy&action=translate&optional=1

Thanks for the patch.