[components-api] Use an asynchronous toolforge client to interact with toolforge
Closed, InvalidPublic
Actions

Assigned To

Authored By

	dcaro
	Nov 5 2024, 10:38 AM

Description

Otherwise when doing calls to toolforge, the fastapi server blocks and prevents serving any new requests.

Luckily, we can now generate it from the openapi def :)

Ex. https://gitlab.wikimedia.org/dcaro/toolforge_cli_gen

Related Objects
Search...

Status	Assigned	Task
Resolved	LucasWerkmeister	T320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
Resolved	matmarex	T319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
Resolved	Legoktm	T320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
Resolved	Legoktm	T320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
In Progress	dcaro	T194332 [builds-api,components-api,webservice,jobs-api] Make Toolforge a proper platform as a service with push-to-deploy and build packs
In Progress	komla	T368600 [KR] WE6.3 Introduce a sustainability scoring system for the Toolforge platform
Resolved	dcaro	T375199 [Hypothesis] WE6.3.4 If we enable the automatic deployment of a minimal tool, we will be able to evaluate the end to end flow and set the groundwork for adding support for more complex tools and deployment flows.
Resolved	dcaro	T362051 [components-api] First iteration of the component API
Invalid	dcaro	T379053 [components-api] Use an asynchronous toolforge client to interact with toolforge

Event Timeline

dcaro created this task.Nov 5 2024, 10:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2024, 10:38 AM

dcaro triaged this task as High priority.Nov 5 2024, 10:39 AM

dcaro added a parent task: T362051: [components-api] First iteration of the component API.

dcaro changed the task status from Open to In Progress.Nov 5 2024, 4:27 PM

dcaro claimed this task.

dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 16) board.

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-weld/-/merge_requests/65

api_client: add the async version of the API client

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/36

use async toolforge cli

dcaro updated https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/36

use async toolforge cli

This might not actually be needed :)

Reading https://fastapi.tiangolo.com/async/ and doing some tests to verify

Yep, we don't need to use async libraries to avoid the api from getting blocked, it will handle non-async code in a threadpool automatically and "do the right thing",

Dropping this task and the MRs :)

dcaro closed this task as Resolved.Nov 7 2024, 11:30 AM

dcaro changed the task status from Resolved to Invalid.

dcaro moved this task from In Progress to Done on the Toolforge (Toolforge iteration 16) board.

dcaro closed https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-weld/-/merge_requests/65

api_client: add the async version of the API client

dcaro closed https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/36

use async toolforge cli

[components-api] Use an asynchronous toolforge client to interact with toolforgeClosed, InvalidPublicActions

Description

Related ObjectsSearch...

Event Timeline

[components-api] Use an asynchronous toolforge client to interact with toolforge
Closed, InvalidPublic
Actions

Related Objects
Search...