Update Nuke to use the Revision table instead of Recent Changes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Samwalton9-WMF
	Nov 6 2024, 11:52 AM

Description

Following our investigation in T33858, we found that - given the testing that is possible outside production Wikimedia projects - moving to the Revision table may not incur a significant performance impact, especially with a time range similar to what is possible using the Recent Changes table currently (T33858#10274759).

As a first step we'll switch over to the Revision table, but with the same time range as is currently possible with Recent Changes - 30 days. This will enable us to test the real-world impact.

WIP patch from Spike ticket: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Nuke/+/1082077/

As part of this work we'll need to add an internal configuration variable to set the max age that we use for the revision table query - by default this should be 30 days to start.

We also need to update https://www.mediawiki.org/wiki/Extension:Nuke and related documentation.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use revision table instead of recentchanges	mediawiki/extensions/Nuke	master	+102 -13

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Chlod	T375757 WE1.3.3: If we improve the user experience and features of the Nuke extension ...
Resolved	Chlod	T379147 Update Nuke to use the Revision table instead of Recent Changes
Resolved	Kgraessle	T33858 [SPIKE] Investigate using the Revision table instead of Recent Changes for Nuke, to allow deleting older pages [16HRS]

Event Timeline

Samwalton9-WMF created this task.Nov 6 2024, 11:52 AM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptNov 6 2024, 11:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwalton9-WMF mentioned this in T33858: [SPIKE] Investigate using the Revision table instead of Recent Changes for Nuke, to allow deleting older pages [16HRS].Nov 6 2024, 11:54 AM

Samwalton9-WMF updated the task description. (Show Details)

Samwalton9-WMF set the point value for this task to 3.Nov 7 2024, 3:02 PM

Samwalton9-WMF updated the task description. (Show Details)Nov 7 2024, 3:06 PM

I'm going to assign these in advance so that it's clear on our workboard that ownership of this work is already clear!

Samwalton9-WMF added a parent task: T375757: WE1.3.3: If we improve the user experience and features of the Nuke extension ....Nov 7 2024, 5:49 PM

Chlod changed the task status from Open to In Progress.Nov 11 2024, 11:58 PM

Chlod moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change #1089919 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):

[mediawiki/extensions/Nuke@master] Use revision table instead of recentchanges

https://gerrit.wikimedia.org/r/1089919

gerritbot added a project: Patch-For-Review.Nov 12 2024, 2:02 AM

Ready for review. The new configuration variable for Nuke's max age is $wgNukeMaxAge. It's 0 by default, which implies that it should get its value from $wgRCMaxAge. This should mean that Nuke should still work as it did before on every wiki, regardless of what they've set $wgRCMaxAge to be (this goes for a lot of third-party wikis; WMF wikis have this set to 30 days).

Per Ladsgroup's suggestion, max execution time is also set with the getNewPages query, using $wgMaxExecutionTimeForExpensiveQueries as a value (same with Special:RecentChanges, 30 seconds on Wikimedia wikis).

Samwalton9-WMF updated the task description. (Show Details)Nov 12 2024, 11:18 AM

Samwalton9-WMF moved this task from Backlog to Enhancements on the MediaWiki-extensions-Nuke board.Nov 12 2024, 1:35 PM

Samwalton9-WMF mentioned this in T379624: Note how many pages were eligible to be listed, but are not listed due to time range constraints.Nov 12 2024, 1:46 PM

Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Nov 12 2024, 3:45 PM

Scardenasmolinar moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.Nov 12 2024, 7:01 PM

Change #1089919 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Use revision table instead of recentchanges

https://gerrit.wikimedia.org/r/1089919

Maintenance_bot removed a project: Patch-For-Review.Nov 12 2024, 7:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Nov 12 2024, 8:00 PM

Nemoralis awarded a token.Nov 14 2024, 5:09 PM

Nemoralis subscribed.