Page MenuHomePhabricator

Clicking "discard changes" also removes any changes made prior to clicking
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Type some content into a page with Edit Recovery enabled
  • Stop editing without saving (so that the changes are stored in Edit Recovery)
  • Start editing that page again, entering some content, and ignore the Edit Recovery popup
  • Now click "discard changes"

What happens?:

  • The popup closes
  • The stored Edit Recovery data is removed
  • Any newly-unsaved changes you've made to the page are removed from the editor (i.e. it is reset to the currently saved state of wikitext)

What should have happened instead?:

  • The popup closes
  • The stored Edit Recovery data is removed
  • Any newly-unsaved changes you've made to the page are not removed from the editor

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1088456 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] EditRecovery: Do not reload form data when discarding recovery

https://gerrit.wikimedia.org/r/1088456

Change #1088456 merged by jenkins-bot:

[mediawiki/core@master] EditRecovery: Do not reload form data when discarding recovery

https://gerrit.wikimedia.org/r/1088456