Page MenuHomePhabricator

Make Nuke tag translatable
Closed, ResolvedPublic2 Estimated Story Points

Description

In T366068 we added a Nuke tag for deletions. We got feedback that it should be localisable, which we hadn't considered in the initial implementation.

We should make that tag a translatable system message, so that it could be edited at MediaWiki:Tag-Nuke, for example, as for other tags.

Details

Related Changes in Gerrit:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwalton9-WMF set the point value for this task to 2.Nov 7 2024, 3:00 PM

We noticed that we made this tag code tag-Nuke when it should have been tag-nuke. As part of this ticket we should update that too.

We could also create a script to run back and update the old tags, but there are relatively few so far so this may not be a high priority. I'll file a separate task.

Chlod changed the task status from Open to In Progress.Nov 8 2024, 4:36 PM

Steps to take here would be to change the symbolic name of the tag (right now Nuke) to nuke (to comply with the message key convention), then add the message for it in {en,qqq}.json.

Still unsure as to how to go around fixing the old entries. I know that it's something to do along the lines of UPDATE ct_tag_def SET ctd_name = "nuke" WHERE ctd_name = "Nuke" but I have no clue of the process required to get that done on production (and if we have to run that through maintenance scripts or something else).

I'm also wondering if it's worth backporting this to 1.44.0-wmf.1 and 1.44.0-wmf.2. (And, in case this doesn't get merged fast enough, probably 1.44.0-wmf.3 too?)

Change #1088645 had a related patch set uploaded (by Chlod Alejandro; author: Chlod Alejandro):

[mediawiki/extensions/Nuke@master] Make Nuke tag translatable

https://gerrit.wikimedia.org/r/1088645

Change #1088645 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Make Nuke tag translatable

https://gerrit.wikimedia.org/r/1088645

Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar subscribed.

I have checked in zhwiki, where a translation for the Nuke tag exists, and have verified that the tag is showing its translation correctly. Moving this to Done and resolving.

We noticed that we made this tag code tag-Nuke when it should have been tag-nuke. As part of this ticket we should update that too.

We could also create a script to run back and update the old tags, but there are relatively few so far so this may not be a high priority. I'll file a separate task.

All the log entries under https://en.wikipedia.org/wiki/Special:Log?type=delete&user=&page=&wpdate=&tagfilter=Nuke&subtype=&wpFormIdentifier=logeventslist should indeed be moved to https://en.wikipedia.org/wiki/Special:Log?type=delete&user=&page=&wpdate=&tagfilter=nuke&subtype=&wpFormIdentifier=logeventslist. You may create a task that would create a maintenance script changing all of the old "Nuke" tags to "nuke" tags.

We noticed that we made this tag code tag-Nuke when it should have been tag-nuke. As part of this ticket we should update that too.

We could also create a script to run back and update the old tags, but there are relatively few so far so this may not be a high priority. I'll file a separate task.

All the log entries under https://en.wikipedia.org/wiki/Special:Log?type=delete&user=&page=&wpdate=&tagfilter=Nuke&subtype=&wpFormIdentifier=logeventslist should indeed be moved to https://en.wikipedia.org/wiki/Special:Log?type=delete&user=&page=&wpdate=&tagfilter=nuke&subtype=&wpFormIdentifier=logeventslist. You may create a task that would create a maintenance script changing all of the old "Nuke" tags to "nuke" tags.

Thanks for the reminder - I just filed T381598.