Consider supporting chart subtitles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Nov 6 2024, 5:31 PM

Description

Spun out from T375235

Background

It is possible to have charts with a title and subtext
e.g. the text "Data from..." on https://echarts.apache.org/examples/en/editor.html?c=bar-polar-real-estate

Screenshot 2024-11-06 at 9.30.56 AM.png (708×1 px, 103 KB)

Use story

TBC - what is the use case for adding subtext

Acceptance criteria

From T375235:

Title subtext should be font size 14
Title subtext color should be #54595D in light mode, #A2A9B1 in dark mode

Details

Other Assignee: aude

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Set width for the chart subtitle	mediawiki/extensions/Chart	master	+38 -0
	Support chart subtitle	mediawiki/extensions/Chart	master	+41 -0

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Support chart subtitle	repos/mediawiki/services/chart-renderer!92	aude	T379180-subtitles	main
	Support chart subtitle	repos/mediawiki/services/chart-renderer!83	simon04	T379180	main

Customize query in GitLab

Related Objects

Mentioned In: T394959: Chart title has no validation, allowing non-localized, plain string in the chart definition
Mentioned Here: T375235: Apply default styling for charts

Event Timeline

Jdlrobson created this task.Nov 6 2024, 5:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2024, 5:31 PM

Jdlrobson triaged this task as Medium priority.Nov 6 2024, 7:26 PM

Isochrone subscribed.Jan 2 2025, 2:00 PM

CCiufo-WMF lowered the priority of this task from Medium to Low.May 1 2025, 3:07 AM

I think you mean subtitle here not subtext.

Bugreporter2 awarded a token.May 5 2025, 11:52 PM

simon04 opened https://gitlab.wikimedia.org/repos/mediawiki/services/chart-renderer/-/merge_requests/83

Support chart subtitle

Change #1143160 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/Chart@master] Support chart subtitle

https://gerrit.wikimedia.org/r/1143160

CCiufo-WMF renamed this task from Consider supporting title "subtext" to Consider supporting chart subtitles.May 8 2025, 6:33 PM

CCiufo-WMF moved this task from Backlog to Up Next on the Charts board.

Jdlrobson-WMF edited projects, added Charts (Current Sprint); removed Charts.May 8 2025, 7:12 PM

@simon04 assigning you since you are the patch author.

Bugreporter2 unsubscribed.May 10 2025, 1:54 PM

Jdlrobson-WMF updated Other Assignee, added: aude.May 12 2025, 7:02 PM

Jdlrobson-WMF moved this task from Code Review to Doing on the Charts (Current Sprint) board.May 13 2025, 5:23 PM

Jdlrobson-WMF moved this task from Doing to Code Review on the Charts (Current Sprint) board.May 19 2025, 6:08 PM

aude mentioned this in T394959: Chart title has no validation, allowing non-localized, plain string in the chart definition.Jun 4 2025, 3:27 PM

Hey @simon04 ! Just wondering if you've had a chance to work on the code review comments from @aude. We're hoping to land this in the next 2 weeks. Happy to support you with this more or make the changes ourselves if you're not available right now.