Page MenuHomePhabricator

Create "Type of incident" selection screen
Closed, ResolvedPublic

Assigned To
Authored By
kostajh
Nov 7 2024, 12:46 PM
Referenced Files
F57700334: image.png
Nov 14 2024, 7:37 AM
F57700325: image.png
Nov 14 2024, 7:37 AM
F57700323: image.png
Nov 14 2024, 7:37 AM
F57700321: image.png
Nov 14 2024, 7:37 AM
F57700330: image.png
Nov 14 2024, 7:37 AM
F57700328: image.png
Nov 14 2024, 7:37 AM
F57700313: image.png
Nov 14 2024, 7:37 AM
F57687509: image.png
Nov 7 2024, 1:03 PM

Description

The first step of opening the reporting dialog is to see a "Type of incident" screen:

Step 1
image.png (732×470 px, 65 KB)

In this task, we should create the screen and two radio button selections. We should also add the options for the "immediate threat" selection:

image.png (352×402 px, 54 KB)

We will also add the custom footer per workflow:

Non-emergency
image.png (746×448 px, 82 KB)
Emergency
image.png (746×448 px, 100 KB)

Acceptance criteria:

  • Opening the incident report dialog, I see two options for "unacceptable user behavior" and "Immediate threat of physical harm"
  • Clicking "Unacceptable user behavior" leads to a subsequent screen
  • Clicking "Immediate threat of physical harm" allows the user to choose from pre-defined options
  • Pressing "Continue" without selecting an incident type triggers a validation error
  • Pressing "Continue" after selecting an emergency option but not specifying a subtype triggers a validation error
  • A footer is shown conditionally when "Unacceptable user behavior" is selected
  • A footer is shown conditionally when "Immediate threat of physical harm" is selected

Related Objects

StatusSubtypeAssignedTask
ResolvedMadalina
ResolvedMadalina
ResolvedDesignKColeman-WMF
ResolvedDesignKColeman-WMF
ResolvedDesignKColeman-WMF
ResolvedDesignKColeman-WMF
Resolved mszabo
ResolvedMadalina
InvalidNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
ResolvedNone
DeclinedNone
Resolved mszabo
Declinedkostajh
ResolvedNone
Resolvedkostajh

Event Timeline

Change #1088560 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] dialog: Rework dialog to add a "Describe the incident" screen

https://gerrit.wikimedia.org/r/1088560

Change #1088560 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] dialog: Start with a "Describe the incident" screen

https://gerrit.wikimedia.org/r/1088560

For QA, please review the acceptance criteria in the task description. Note that the second screen (after pressing "Continue") is not yet implemented according to the revised workflows. So, QA should focus only on interactions on the initial screen shown when loading the incident reporting dialog.

Djackson-ctr subscribed.

QA has been completed and the new code changes have been implemented.
Thank you for the QA notes @kostajh.

image.png (672×1 px, 88 KB)

image.png (455×700 px, 35 KB)

image.png (738×1 px, 101 KB)

image.png (730×1 px, 138 KB)

image.png (788×1 px, 148 KB)

image.png (819×1 px, 141 KB)

image.png (483×712 px, 43 KB)