Page MenuHomePhabricator

SUL3 login breaks when using the user toolbar to switch between login and signup
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enable SUL3
  • Click "Login"
  • Click "Create account" in the user toolbar (top right)
  • Create an account

What happens?:
You land on an error page saying "The provided authentication token is either expired or invalid."
(The account does get created.)

When using the "Join <wiki>" button that's part of the login form, things work, because the AuthPreserveQueryParams hook gets applied when generating the link. But it's not used for the login and signup links in the user toolbar. So either we need to fix that, or we need to handle the normal link syntax (probably this means, when centralauthLoginToken is missing, we check if it's present in returntoquery, and if it is, we merge returntoquery into the current URL).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1088454 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] Fetch auth token from `returntoquery` on link switch in toolbar

https://gerrit.wikimedia.org/r/1088454

DAlangi_WMF changed the task status from Open to In Progress.Fri, Nov 8, 7:35 AM

Change #1088614 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] [SUL3] skins: Special:(Userlogin|CreateAccount) pages in SUL3 mode

https://gerrit.wikimedia.org/r/1088614

Change #1088454 abandoned by D3r1ck01:

[mediawiki/extensions/CentralAuth@master] SUL3: Fetch token from `returntoquery` on link switch in toolbar

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1088614, will resurrect this if needed.

https://gerrit.wikimedia.org/r/1088454

Change #1088614 merged by jenkins-bot:

[mediawiki/core@master] [SUL3] skins: Special:(Userlogin|CreateAccount) pages in SUL3 mode

https://gerrit.wikimedia.org/r/1088614

Change #1092422 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] skins: Improve 'returnto' params in login/signup links

https://gerrit.wikimedia.org/r/1092422

Change #1092422 merged by jenkins-bot:

[mediawiki/core@master] skins: Improve 'returnto' params in login/signup links

https://gerrit.wikimedia.org/r/1092422