dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/5114

Here is an APK with the implementation so far:
https://github.com/wikimedia/apps-android-wikipedia/actions/runs/11917094545/artifacts/2208377492

When first running the app, it will randomly assign you to one of the A/B/C test groups. To change your test group, go to Developer settings, scroll all the way to the bottom, and find the Test group for Rabbit Holes setting. You can set this to either 0 (control group), 1 (suggested search), or 2 (suggested reading list).

thank you @Dbrant!

some notes:

1. can we load the suggested search query immediately? right now there’s a bit of a lag time, where Search Wikipedia is seen:

2. when a user loads a new page, the former suggested search query should already be gone — right now it is still there for a split second:

3. can the purple highlight be removed from the suggested search query when a user presses enter?:

4. can we ensure that the background behind the suggested search query under the Related to what you’re reading heading is a gradient, rather than a slightly opaque blue? it should also have 8px left and right padding.

Latest apk (same as the other task): https://github.com/wikimedia/apps-android-wikipedia/actions/runs/11961520798/artifacts/2221182539

In T379379#10342145, @SChekfa-WMF wrote:

1. can we load the suggested search query immediately? right now there’s a bit of a lag time, where Search Wikipedia is seen:

Afraid not; this is as immediate as it can be, since there will always be a round-trip time for retrieving a suggestion based on the current article.

2. when a user loads a new page, the former suggested search query should already be gone — right now it is still there for a split second:

Done! (This will reset the search hint back to "Search Wikipedia", until it gets repopulated with a new suggestion for the current article.)

3. can the purple highlight be removed from the suggested search query when a user presses enter?:

Done!

4. can we ensure that the background behind the suggested search query under the Related to what you’re reading heading is a gradient, rather than a slightly opaque blue? it should also have 8px left and right padding.

I've made it into a gradient, but it doesn't look exactly like the gradient in the design, because it's not clear what color tokens the design is using. It looks like the desired gradient goes from #6699FF at 8%, to #FFFFFF at 40%, neither of which correspond to a known color token. (i.e. What should it be in Dark / Black / Sepia modes?)
In the current APK, I have assumed that the gradient goes from multi_select_background_color to paper_color, according to our theme guidelines.

1. makes sense, thank you for looking into this!

2. LGTM, TY!

3. LGTM, TY!

4. ah I see! so I was actually referencing the color library in Figma — specifically the last line with the slightly opaque blues, specifically #blue300, which is #6699FF at 20% — this doesn't show up in the file because when you use gradients as Figma, the tokens can't be applied to the endpoints (AFAIK!). I'm also seeing that this row is titled addition (TBD) so was this not built into the system @Dbrant ? in any case, I like the version you implemented, so let's stick with that.

Working for me on 2.7.50512-r-2024-12-02

@Dbrant or @SChekfa-WMF I'm only seeing the survey after actually pressed enter or clicked on the recommendation, but not after interacting with search and ignoring the recommendation multiple times. Was this explicitly how Jaz wanted it set up?

I ask because it might give us a warped view of the KR: 65% or higher of feedback scores are positive, as we're only ever asking people who actually acted on our recommendation, not those who ignored it.

In T379379#10381886, @HNordeenWMF wrote:

@Dbrant or @SChekfa-WMF I'm only seeing the survey after actually pressed enter or clicked on the recommendation, but not after interacting with search and ignoring the recommendation multiple times. Was this explicitly how Jaz wanted it set up?

Yep, it was intended for the survey to pop up only after the user clicks-through to a recommended search result.

Got it! It looks good to me then.