Page MenuHomePhabricator

[L] Rabbit Holes: Suggested reading list
Closed, ResolvedPublic

Assigned To
Authored By
Dbrant
Nov 8 2024, 3:30 PM
Referenced Files
F57733283: image.png
Nov 22 2024, 4:32 PM
F57733281: image.png
Nov 22 2024, 4:32 PM
F57733272: image.png
Nov 22 2024, 4:32 PM
F57725880: image.png
Nov 20 2024, 7:26 PM
F57725877: image.png
Nov 20 2024, 7:26 PM

Description

This is the engineering task to build the second "half" of the rabbit holes experiment:

  • Since this is an ABC test, users in the A group will be the control, and the C group shall see the "suggested reading list" mode.
  • If the user is in the C group, upon opening an article, generate a reading list of 10 articles. This will likely be done with a morelike query based on the last 1 or 2 articles in the user's local history. (If the user has no articles in their history, this will not be shown.)
  • This suggested reading list will be persisted for the duration of the experiment (i.e. will not be dynamic or regenerated).
  • This suggested list will be presented in the user's "Saved" screen, along with their existing reading lists, but with a slightly different design.
  • If the user taps the suggested list, it appears the same way as the workflow to import a shared reading list. If the user chooses to "save" this suggested list, it will become a regular list along with any others.
  • When the suggested list is initially generated, the user is presented with a dialog box asking if they want to see this suggested reading list. If they tap Yes, it takes them directly to the above importing workflow.
  • Make sure to build the workflow in such a way that analytics can be threaded through it easily.

https://www.figma.com/design/Z2n0gZOOAbgsIdHgUS5ocQ/Android-%E2%86%92-Rabbit-Holes-%E2%86%92-T378612?node-id=2-7&node-type=canvas&t=I1LAxYHuhyWTjrc8-0

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedDbrant

Event Timeline

Dbrant triaged this task as Medium priority.Nov 8 2024, 3:34 PM

Here is an APK with the implementation so far:
https://github.com/wikimedia/apps-android-wikipedia/actions/runs/11917094545/artifacts/2208377492

When first running the app, it will randomly assign you to one of the A/B/C test groups. To change your test group, go to Developer settings, scroll all the way to the bottom, and find the Test group for Rabbit Holes setting. You can set this to either 0 (control group), 1 (suggested search), or 2 (suggested reading list).

For group 2 (reading list), there is another Developer switch called suggestedReadingListDialogShown. This becomes ON when you go to an article and a reading list is generated and offered to you. If you set this switch back to OFF, the reading list will be regenerated (and offered again) on the next article you visit.

hi @Dbrant, thanks so much for your work on this!

some notes:

  1. would it be possible to ensure that the headline in the announcement dialog is centered? (I recognize that the spacing is a function of the existing component we have in use, so disregard that discrepancy between the design and implementation!)
  1. can we remove the quotes around the two history items in the list description?

image.png (1,080×2,340 px, 960 KB)

  1. if possible, could we please update the styles within the Experiment label? realizing that the label Alex created for WikiGames was probably never implemented, so [[ https://www.figma.com/design/Z2n0gZOOAbgsIdHgUS5ocQ/Android-%E2%86%92-Rabbit-Holes-%E2%86%92-T378612?node-id=157-11027&t=e4aPVW1qaJqixvUk-1 | I've assigned existing styles to the label ]]in alignment with the current tenets of the design system: the background pulls the #background token, the border around the pill pulls the #border token, and the text token is pulling the <chip> type token.
  1. the placeholder name for the reading list, when a user moves to save (part of or all of) the reading list, should be the title of the suggested reading list: "Based on your reading." Right now it is the same as the shared reading list:

image.png (1,080×2,340 px, 680 KB)

  1. The "About this experiment" label should hyperlink to the Rabbit Holes MediaWiki page. Right now it doesn't appear to be linking anywhere.

latest APK: https://github.com/wikimedia/apps-android-wikipedia/actions/runs/11961520798/artifacts/2221182539

  1. would it be possible to ensure that the headline in the announcement dialog is centered? (I recognize that the spacing is a function of the existing component we have in use, so disregard that discrepancy between the design and implementation!)

This is using our standard Dialog component, which has a left-aligned title. If we center one, we must center all.

  1. can we remove the quotes around the two history items in the list description?

Done!

  1. if possible, could we please update the styles within the Experiment label? realizing that the label Alex created for WikiGames was probably never implemented, so [[ https://www.figma.com/design/Z2n0gZOOAbgsIdHgUS5ocQ/Android-%E2%86%92-Rabbit-Holes-%E2%86%92-T378612?node-id=157-11027&t=e4aPVW1qaJqixvUk-1 | I've assigned existing styles to the label ]]in alignment with the current tenets of the design system: the background pulls the #background token, the border around the pill pulls the #border token, and the text token is pulling the <chip> type token.

Done!

  1. the placeholder name for the reading list, when a user moves to save (part of or all of) the reading list, should be the title of the suggested reading list: "Based on your reading." Right now it is the same as the shared reading list:

Done!

  1. The "About this experiment" label should hyperlink to the Rabbit Holes MediaWiki page. Right now it doesn't appear to be linking anywhere.

Done!

  1. @Dbrant okay for sure — let's hold off on this — I'll add a ticket to the backlog to review all other use cases for the dialog to ensure that this change suits every scenario before we update.
  1. ah for some reason for me I'm seeing the quotes sometimes and sometimes no quotes — maybe this is a caching issue?:

image.png (1,080×2,340 px, 410 KB)

  1. LGTM, TY!
  1. LGTM, TY!
  1. LGTM, TY!

————

new bug(?) — do you know why this recommended reading list is showing "Main Page" as one of the two sources from where the recommendations are being generated? What is "Main Page" — the explore page? My most recent reading history is as follows:

image.png (1,080×2,340 px, 1 MB)

image.png (1,080×2,340 px, 183 KB)

  1. ah for some reason for me I'm seeing the quotes sometimes and sometimes no quotes — maybe this is a caching issue?:

This was likely a holdover from the previous install of the APK. If you start over and generate a new list, it should no longer have quotes.

new bug(?) — do you know why this recommended reading list is showing "Main Page" as one of the two sources from where the recommendations are being generated? What is "Main Page" — the explore page? My most recent reading history is as follows:

Good catch -- we will now exclude Main Page from potential candidates for reading list suggestions.

that makes sense!

and perfect, thank you for updating.

Dbrant renamed this task from Rabbit Holes: Suggested reading list to [L] Rabbit Holes: Suggested reading list.Dec 2 2024, 6:12 PM

@Dbrant it looks like the same survey is displaying for group C & B, with the title "Help improve rabbit holes Are you satisfied with this recommended search result?", instead of switching to reading list title for Group C. This might be confusing for users - as it references "Rabbit holes" and "recommended search results" with no mention of the suggested reading list.

Would recommend using the copy if possible

Help improve recommended reading lists.
Are you satisfied with this recommended reading list?