Page MenuHomePhabricator

Document TransitionEvent fields
Open, Needs TriagePublic

Description

From 1043786:

"For TransitionEvent, I'm interpreting that @private tag as referring to the constructor in particular, that is, one isn't supposed to instantiate that class.
However, as I understand it, the static fields like TransitionEvent.BUILTIN, TransitionEvent.MW_HOOK, etc., are what is provided as arguments to the callback parameter of the public and user facing StepBuilder::transition method. So we probably want them to be documented where they are defined."

To do

This task is for the GuidedTour extension. For contributing instructions, see Gerrit/Tutorial.

Approach

In my initial testing, I was only able to get the properties to appear corectly using a forced memberof annotation (@memberof!), but there may be a better way to do this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1092289 had a related patch set uploaded (by Pppery; author: GauriGuptaa):

[mediawiki/extensions/GuidedTour@master] Document TransitionEvent fields and add JSDoc

https://gerrit.wikimedia.org/r/1092289

Change #1185302 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/GuidedTour@master] GuidedTour: Document TransitionEvent fields for JSDoc

https://gerrit.wikimedia.org/r/1185302

Hi all,

I’ve addressed the comments from the previous PR and made the necessary fixes. I’ve submitted the updated PR — could someone please check and review it

Here’s the PR link: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/1185302

~Thanks

Pppery removed a project: good first task.
Pppery subscribed.
This comment was removed by Pppery.