[regression] VE mobile menu items unexpectedly bold
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Nov 8 2024, 9:25 PM

Project Tags

Referenced Files

	F58856985: screenshot 133.png
	Mar 18 2025, 3:03 AM

	F58856984: screenshot 132.png
	Mar 18 2025, 3:03 AM

	F58702058: screenshot 84.png
	Mar 9 2025, 12:19 AM

	F58702057: screenshot 83.png
	Mar 9 2025, 12:19 AM

	F57689848: image.png
	Nov 8 2024, 9:25 PM

	F57689845: image.png
	Nov 8 2024, 9:25 PM

Subscribers

Description

Since this commit: https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1073500

Observed

Expected

Requirement

Ensure that VisualEditor (VE) mobile menu items are not bold.

BDD

Feature: Fix bold styling of VE mobile menu items  

  Scenario: VE mobile menu items are not bold  
    Given I visit a Minerva-skinned page with VisualEditor enabled  
    When I open the VisualEditor mobile menu  
    Then the menu items should not be bold

Test Steps

Test Case 1: Verify VE mobile menu items are not bold

Visit a Minerva-skinned page with VisualEditor enabled.
Open the VisualEditor mobile menu.
AC1: Confirm that the menu items are not bold.

QA Results - Beta

AC	Status	Details
1	✅	T379428#10616045

QA Results - Prod

AC	Status	Details
1	✅	T379428#10645021

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Follow-up Iefa1fee9c: Remove bold styling from all non-href links	mediawiki/skins/MinervaNeue	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T387364: Verify 1.44.0-wmf.20 deployment
Mentioned Here: T181472: "a.mw-selflink" links miss styling

Event Timeline

Esanders created this task.Nov 8 2024, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2024, 9:25 PM

Change #1088643 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Follow-up Iefa1fee9c: Remove bold styling from all non-href links

https://gerrit.wikimedia.org/r/1088643

gerritbot added a project: Patch-For-Review.Nov 8 2024, 9:28 PM

Esanders triaged this task as Medium priority.Nov 8 2024, 9:29 PM

Jdlrobson added a project: Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4).Nov 8 2024, 10:01 PM

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4) board.Nov 12 2024, 5:17 PM

NBaca-WMF added a project: Web-Team.Nov 13 2024, 2:54 PM

Jdlrobson moved this task from Incoming to Sprint Backlog on the Web-Team board.Nov 13 2024, 11:19 PM

Jdlrobson moved this task from Sprint Backlog to Incoming on the Web-Team board.Nov 13 2024, 11:57 PM

ppelberg subscribed.Nov 14 2024, 5:51 AM

Jdlrobson moved this task from Incoming to Sprint Backlog on the Web-Team board.Nov 14 2024, 11:38 PM

Jdlrobson set the point value for this task to 2.

When picking this up, make a post in #talk-to-web and CC the author of the ticket to make sure this is a priority to be done, per our established norms

Leaving in the sprint backlog for now for this reason

Jdlrobson moved this task from Sprint Backlog to Incoming on the Web-Team board.Dec 2 2024, 7:20 PM

Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.Jan 2 2025, 9:40 PM

Jdlrobson moved this task from Incoming to Q3 on the Web-Team board.Jan 16 2025, 7:01 PM

Jdlrobson-WMF moved this task from Q3 to Sprint Backlog on the Web-Team board.Jan 31 2025, 7:27 PM

ovasileva moved this task from Sprint Backlog to Q3 on the Web-Team board.Feb 6 2025, 2:37 PM

Change #1088643 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Follow-up Iefa1fee9c: Remove bold styling from all non-href links

https://gerrit.wikimedia.org/r/1088643

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 5 2025, 9:00 PM

matmarex closed this task as Resolved.Mar 5 2025, 9:20 PM

matmarex assigned this task to Esanders.

matmarex removed a project: Patch-For-Review.

ovasileva edited projects, added: Web-Team (Q3 Sprint 4 (Mar 5, 2025 - Mar 19, 2025)); removed: Web-Team.Mar 6 2025, 10:12 AM

Re-opening so we can do some QA

This was a task affecting the editing experience and we communicated the priority when filing the task. Not sure why it was lowered?

Esanders updated the task description. (Show Details)Mar 6 2025, 4:47 PM

Jdlrobson-WMF moved this task from Ready for development to In progress on the Web-Team (Q3 Sprint 4 (Mar 5, 2025 - Mar 19, 2025)) board.Mar 6 2025, 4:51 PM

Jdlrobson-WMF added a project: Unplanned-Sprint-Work.Mar 6 2025, 5:01 PM

Test Steps

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS

Test Case 1: Verify VE mobile menu items are not bold

Visit a Minerva-skinned page with VisualEditor enabled.
Open the VisualEditor mobile menu.
✅ AC1: Confirm that the menu items are not bold.

Edtadros updated the task description. (Show Details)Mar 9 2025, 12:20 AM

Jdlrobson-WMF assigned this task to ovasileva.Mar 10 2025, 4:25 PM

@ovasileva looking at the change, this would unbold any anchor element which doesn't have an href attribute.

I know historically we had some of these. Looking at the git history, the rule was introduced in T181472 due to some styling issues with talk, last modified and main menu. None of those are impacted in the modern version.

I looked through our mobile workflows for any instance of $('a:not([href]):not(.mw-selflink)') and I do not see any impact so I think there is low risk of impact to other parts of the interface.

The most likely place for regressions would be special pages so we should keep an eye out for bug reports and recommend they add the mw-selflink class where needed.

Edtadros mentioned this in T387364: Verify 1.44.0-wmf.20 deployment.Mar 18 2025, 2:12 AM