Page MenuHomePhabricator
Create Task
Maniphest T379481

[GENERAL] PHP 8.4 issues in WMDE/Wikidata libraries
Closed, ResolvedPublic
Actions

Description

Starting in PHP 8.4, the “old-style” syntax for nullable parameters like Parser $parser = null is deprecated. It should be changed to ?Parser $parser = null – or, if the parameter should not actually have a default argument, to just ?Parser $parser. This is required for compatibility with PHP 8.4 (which is currently used by some developers and will be used in production in future) without raising tons of deprecation warnings.

Acceptance criteria:

  • The libraries listed below use the latest version of the MediaWiki codesniffer config.
    • data-values/common
    • data-values/geo
    • data-values/interfaces
    • data-values/number
    • data-values/time
    • diff/diff
    • serialization/serialization
    • wmde/hamcrest-html-matchers
  • New versions of the libraries have been released
    • data-values/common
    • data-values/geo
    • data-values/interfaces
    • data-values/number
    • data-values/time
    • diff/diff
    • serialization/serialization
    • wmde/hamcrest-html-matchers
  • The new versions are used in Wikibase / mediawiki/vendor.git.
  • The PHPCS rule MediaWiki.Usage.NullableType.ExplicitNullableTypes is not disabled in their .phpcs.xml.
  • Any violations have been fixed.

cf T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated and T379509: [GENERAL] Fix implicit nullable types in Wikibase

In T376276#10306963, Umherirrender wrote:

Running the sniff from T362014 against mediawiki/vendor shows many code in different packages

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace calls to deprecated `defaultOption` with `withDefaultOption`mediawiki/extensions/Wikibasemaster+73 -52
Upgrade wikibase-related libraries for PHP 8.4 compatibilitymediawiki/vendormaster+588 -398
Loosen data-values/number version constraint to prepare updatemediawiki/extensions/Wikibasemaster+1 -1
Declare compatibility with data-values/number 0.13.0mediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Nov 10 2024, 2:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2024, 2:08 AM
Maintenance_bot added a project: Wikidata.Nov 10 2024, 2:29 AM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.4 support board.Nov 10 2024, 2:29 AM
Danielyepezgarces mentioned this in T379509: [GENERAL] Fix implicit nullable types in Wikibase.Nov 11 2024, 1:03 AM
Reedy added a parent task: T379509: [GENERAL] Fix implicit nullable types in Wikibase.Nov 11 2024, 1:30 AM
Umherirrender unsubscribed.Nov 11 2024, 7:51 PM
Reedy mentioned this in T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.Nov 11 2024, 10:45 PM
Reedy added a parent task: T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.
Reedy removed a parent task: T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated.
Lucas_Werkmeister_WMDE renamed this task from PHP 8.4 issues in WMDE/Wikidata libraries to [GENERAL] PHP 8.4 issues in WMDE/Wikidata libraries.Nov 21 2024, 2:03 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a subscriber: Umherirrender.
Lucas_Werkmeister_WMDE subscribed.

Prio Notes:

Impact AreaAffected
production / end usersnot yet
monitoring✘
development efforts✔
onboarding efforts✘
additional stakeholders✔ (people who already want to run Wikibase on PHP 8.4)
Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.Nov 21 2024, 2:06 PM
Lucas_Werkmeister_WMDE added a project: [Archived]Wikidata Dev Team.
karapayneWMDE moved this task from Incoming to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.Nov 29 2024, 3:07 PM
ItamarWMDE moved this task from [DOT] Tech Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Dec 4 2024, 11:03 AM
ItamarWMDE moved this task from [DOT] By Project to Wikidata Omega Triage on the wmde-wikidata-tech board.Dec 4 2024, 11:40 AM
ItamarWMDE edited projects, added wmde-wikidata-tech (Wikidata Omega Triage); removed wmde-wikidata-tech.
ItamarWMDE removed a project: wmde-wikidata-tech (Wikidata Omega Triage).
ArthurTaylor claimed this task.Dec 6 2024, 11:38 AM
ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor added a comment.Dec 6 2024, 1:11 PM

Opened PR https://github.com/DataValues/Common/pull/101/files (issue https://github.com/DataValues/Common/issues/100) in data-values/common

ArthurTaylor added a comment.Dec 6 2024, 1:54 PM

Opened PR https://github.com/DataValues/Geo/pull/223 (issue https://github.com/DataValues/Geo/issues/222) in data-values/geo

ArthurTaylor added a comment.Dec 6 2024, 2:07 PM

Opened PR https://github.com/DataValues/Interfaces/pull/63 (issue https://github.com/DataValues/Interfaces/issues/62) in data-values/interfaces

Umherirrender unsubscribed.Dec 6 2024, 2:10 PM
ArthurTaylor added a comment.Dec 6 2024, 2:52 PM

Opened PR https://github.com/wmde/Number/pull/145 in data-values/number

ArthurTaylor added a comment.Dec 6 2024, 3:27 PM

Opened PR https://github.com/wmde/Time/pull/168 in data-values/Time

ArthurTaylor added a comment.Dec 9 2024, 9:40 AM

Opened PR https://github.com/wmde/Serialization/pull/35 in serialization/serialization

ArthurTaylor added a comment.Dec 9 2024, 9:41 AM

Opened PR https://github.com/wmde/Diff/pull/144 in diff/diff

gerritbot added a comment.Dec 9 2024, 11:13 AM

Change #1101486 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Replace calls to deprecated `defaultOption` with `withDefaultOption`

https://gerrit.wikimedia.org/r/1101486

gerritbot added a project: Patch-For-Review.Dec 9 2024, 11:13 AM
ArthurTaylor updated the task description. (Show Details)Dec 11 2024, 8:49 AM
ArthurTaylor added a subscriber: Umherirrender.
ArthurTaylor updated the task description. (Show Details)Dec 11 2024, 8:55 AM
WMDE-leszek subscribed.Dec 11 2024, 12:32 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 11 2024, 2:49 PM
Umherirrender unsubscribed.Dec 11 2024, 7:12 PM
ArthurTaylor updated the task description. (Show Details)Dec 12 2024, 12:17 PM
ArthurTaylor added a subscriber: Umherirrender.
Umherirrender updated the task description. (Show Details)Dec 13 2024, 8:43 PM
Umherirrender unsubscribed.
Reedy added a comment.Dec 13 2024, 10:44 PM

https://github.com/wmde/hamcrest-html-matchers/pull/39

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 16 2024, 2:47 PM
karapayneWMDE removed ArthurTaylor as the assignee of this task.Dec 17 2024, 9:16 AM
karapayneWMDE moved this task from In Development to Ready for Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
karapayneWMDE added subscribers: ArthurTaylor, karapayneWMDE.

Unassigned and moved back to ready for dev as Arthur is OOO this week

ArthurTaylor claimed this task.Jan 6 2025, 8:43 AM
ArthurTaylor moved this task from Ready for Development to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor updated the task description. (Show Details)Jan 6 2025, 9:08 AM
gerritbot added a comment.Jan 6 2025, 9:45 AM

Change #1108396 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/vendor@master] Upgrade wikibase-related libraries for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1108396

ArthurTaylor added a comment.Jan 6 2025, 10:42 AM

The released version of data-values/geo (4.5.0) includes a change to drop support for PHP 7.4. Since our infrastructure still uses PHP 7.4 (T319432), this creates problems for us. I opened an issue and created a pull request to revert the deprecation. Until that is merged and tagged, we can't upgrade to the version of data-values/geo that fixes the PHP 8.4 deprecation issue.

ArthurTaylor updated the task description. (Show Details)Jan 6 2025, 10:43 AM
Lucas_Werkmeister_WMDE added a comment.Jan 6 2025, 11:06 AM
In T379481#10431946, @ArthurTaylor wrote:

The released version of data-values/geo (4.5.0) includes a change to drop support for PHP 7.4. Since our infrastructure still uses PHP 7.4 (T319432), this creates problems for us. I opened an issue and created a pull request to revert the deprecation. Until that is merged and tagged, we can't upgrade to the version of data-values/geo that fixes the PHP 8.4 deprecation issue.

I merged that and tagged 4.5.1 which restores PHP 7.4 support.

gerritbot added a comment.Jan 6 2025, 12:10 PM

Change #1108416 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Loosen data-values/number version constraint to prepare update

https://gerrit.wikimedia.org/r/1108416

gerritbot added a comment.Jan 6 2025, 12:21 PM

Change #1108427 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Declare compatibility with data-values/number 0.13.0

https://gerrit.wikimedia.org/r/1108427

gerritbot added a comment.Jan 6 2025, 12:39 PM

Change #1108416 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Loosen data-values/number version constraint to prepare update

https://gerrit.wikimedia.org/r/1108416

gerritbot added a comment.Jan 6 2025, 12:39 PM

Change #1108427 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Declare compatibility with data-values/number 0.13.0

https://gerrit.wikimedia.org/r/1108427

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 6 2025, 1:00 PM
gerritbot added a comment.Jan 6 2025, 2:25 PM

Change #1108396 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrade wikibase-related libraries for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1108396

ArthurTaylor updated the task description. (Show Details)Jan 7 2025, 6:24 AM
ArthurTaylor updated the task description. (Show Details)Jan 7 2025, 7:00 AM

Codesearch suggests that the rule is not disabled anywhere. The Wikibase code and libraries have been updated.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 7 2025, 7:02 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jan 7 2025, 7:05 AM
Lucas_Werkmeister_WMDE claimed this task.Jan 8 2025, 4:09 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Jan 9 2025, 11:58 AM

Change #1101486 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace calls to deprecated `defaultOption` with `withDefaultOption`

https://gerrit.wikimedia.org/r/1101486

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jan 9 2025, 12:01 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE claimed this task.Jan 10 2025, 1:47 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to In Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 10 2025, 1:50 PM
Lucas_Werkmeister_WMDE reassigned this task from Lucas_Werkmeister_WMDE to ArthurTaylor.
Lucas_Werkmeister_WMDE moved this task from In Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

I think this is done \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits