Notice how the "Kyiv-Pasazhyrskyi railway station" list item has a dark gray line going through it, and below it there's a slightly different gray background on the edges.
In addition the "view all edits" link should have some bottom padding.
| taavi | |
| Nov 10 2024, 8:46 AM |
| F57695031: IMG_5910.PNG | |
| Nov 11 2024, 11:14 PM |
| F57695027: Screen Shot 2024-11-11 at 2.53.42 PM.png | |
| Nov 11 2024, 11:14 PM |
| F57695025: Screen Shot 2024-11-11 at 2.27.03 PM.png | |
| Nov 11 2024, 11:14 PM |
| F57692816: en.m.wikipedia.org_wiki_Special_Impact_Taavi(iPhone 14 Pro Max).png | |
| Nov 10 2024, 8:51 PM |
| F57692809: cs.m.wikipedia.org_w_index.php_title=Speci%C3%A1ln%C3%AD_Domovsk%C3%A1_str%C3%A1nka&namespace=-1&uselang=en(iPhone 14 Pro Max).png | |
| Nov 10 2024, 8:51 PM |
| F57691958: image.png | |
| Nov 10 2024, 8:46 AM |
In addition the "view all edits" link should have some bottom padding.
I'm having troubles reproducing this.
This is what I see at cs.wikipedia Homepage (logged in as Martin Urbanec (WMF)):
Article titles that are too long are wrapping to several lines, as expected.
Judging by the article titles, I expect this is from the English Wikipedia. https://en.wikipedia.org/wiki/Special:Impact/Taavi already shows other articles, but they also wrap to multiple lines:
The same happens when I enable the built in dark mode and regardless of any scrolling.
Is there something special I need to do to reproduce this bug? Moving to Blocked pending clarification.
I think your test device is too tall, as this only happens after having to scroll. Also, it only happens on Special:Homepage, not on Special:Impact.
Thanks, @taavi for filing the issue! I assume that the dark mode on mobile was enabled in Preferences-Gadgets? The issue exists in both - dark and light mode on mobile.
The issue has been confirmed in betalabs and production wikis (testwiki wmf.2) (thx, @Urbanecm_WMF for bringing it to my attention) and it's been checked on a real device, as well as in a browser emulator.
(1) The extra line appears on Impact overlay on mobile:
The same screenshot made on a real device - iPhone (iOS 17).
Thanks both! I see it too now, changing dimensions in browser emulator helped to reproduce it (375 x 667 seems to be enough).
That's...weird, but indeed seems to be the case. Wondering why, as the two modules are supposed to be rendered by the same code.
Anyway, this should now be actionable. Moving to Up Next, so we can take a look. Thanks for reporting!
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3