Page MenuHomePhabricator
Create Task
Maniphest T379566

Remove obsolete Feature Flags
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

These obsolete feature flags are only ever mentioned in GrowthExperiments and can straight-forwardly be removed. There should have one commit per feature flag that removes all mentions of it:

  • GEHelpPanelEnabled
  • WelcomeSurveyEnabled
  • GEHomepageEnabled
  • GEHomepageLoggingEnabled
  • GEConfirmEmailEnabled

The following feature flags also still exist in mediawiki-config in addition to Growth-Experiments and must be removed from there as well:

  • GELevelingUpFeaturesEnabled removed from GrowthExperiments
    • GELevelingUpFeaturesEnabled removed from mediawiki-config
  • GEMentorDashboardEnabled removed from GrowthExperiments
    • GEMentorDashboardEnabled removed from mediawiki-config

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove obsolete WelcomeSurveyEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+14 -28
Growth: Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flagsoperations/mediawiki-configmaster+0 -11
Remove GEMentorDashboardEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+5 -93
Remove GELevelingUpFeaturesEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+1 -12
Remove GEHelpPanelEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+22 -104
Remove GEHomepageLoggingEnabled config flagmediawiki/extensions/GrowthExperimentsmaster+6 -39
Remove GEConfirmEmailEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+0 -17
Remove GEHomepageEnabled configuration flagmediawiki/extensions/GrowthExperimentsmaster+6 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 11 2024, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2024, 3:32 PM
Michael updated the task description. (Show Details)Nov 11 2024, 3:33 PM
Michael mentioned this in T379568: Remove obsolete GENewcomerTasksGuidanceEnabled feature flag.Nov 11 2024, 3:47 PM
Frostly subscribed.Nov 11 2024, 7:51 PM
Michael triaged this task as Medium priority.Nov 12 2024, 4:51 PM
Michael moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.
KStoller-WMF moved this task from Up Next (estimated tasks) to Maintenance on the Growth-Team board.Jan 29 2025, 5:47 PM
KStoller-WMF edited projects, added Growth-Team (Maintenance); removed Growth-Team.
Michael moved this task from Backlog to Unused code removal on the Growth-Team (Maintenance) board.Jan 29 2025, 8:03 PM
Cyndymediawiksim claimed this task.Mar 24 2025, 10:34 AM
Cyndymediawiksim edited projects, added Growth-Team (Current Sprint); removed Growth-Team (Maintenance).
Cyndymediawiksim set the point value for this task to 2.
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Mar 24 2025, 2:22 PM

Change #1130612 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GEHomepageEnabled configuration flag

https://gerrit.wikimedia.org/r/1130612

gerritbot added a project: Patch-For-Review.Mar 24 2025, 2:22 PM
gerritbot added a comment.Mar 25 2025, 8:23 AM

Change #1130603 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove obsolete WelcomeSurveyEnabled feature flag

https://gerrit.wikimedia.org/r/1130603

gerritbot added a comment.Mar 25 2025, 10:28 AM

Change #1130973 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GEHomepageLoggingEnabled config flag

https://gerrit.wikimedia.org/r/1130973

gerritbot added a comment.Mar 25 2025, 12:25 PM

Change #1130999 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GEConfirmEmailEnabled feature flag

https://gerrit.wikimedia.org/r/1130999

gerritbot added a comment.Mar 25 2025, 1:49 PM

Change #1130973 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GEHomepageLoggingEnabled config flag

https://gerrit.wikimedia.org/r/1130973

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 25 2025, 2:00 PM
gerritbot added a comment.Mar 25 2025, 8:22 PM

Change #1130603 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove obsolete WelcomeSurveyEnabled feature flag

https://gerrit.wikimedia.org/r/1130603

gerritbot added a comment.Mar 26 2025, 2:54 PM

Change #1130612 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GEHomepageEnabled configuration flag

https://gerrit.wikimedia.org/r/1130612

gerritbot added a comment.Mar 27 2025, 11:24 AM

Change #1131675 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GEHelpPanelEnabled feature flag

https://gerrit.wikimedia.org/r/1131675

gerritbot added a comment.Mar 27 2025, 12:33 PM

Change #1131696 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[operations/mediawiki-config@master] Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags

https://gerrit.wikimedia.org/r/1131696

gerritbot added a comment.Mar 27 2025, 12:44 PM

Change #1131698 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags

https://gerrit.wikimedia.org/r/1131698

gerritbot added a comment.Mar 27 2025, 3:08 PM

Change #1130999 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GEConfirmEmailEnabled feature flag

https://gerrit.wikimedia.org/r/1130999

gerritbot added a comment.Apr 1 2025, 1:51 PM

Change #1131675 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GEHelpPanelEnabled feature flag

https://gerrit.wikimedia.org/r/1131675

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 1 2025, 2:00 PM
gerritbot added a comment.Apr 2 2025, 7:10 AM

Change #1133305 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GELevelingUpFeaturesEnabled feature flag

https://gerrit.wikimedia.org/r/1133305

Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Apr 2 2025, 8:09 AM
gerritbot added a comment.Apr 2 2025, 12:14 PM

Change #1133305 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GELevelingUpFeaturesEnabled feature flag

https://gerrit.wikimedia.org/r/1133305

gerritbot added a comment.Apr 2 2025, 6:44 PM

Change #1131698 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GEMentorDashboardEnabled feature flag

https://gerrit.wikimedia.org/r/1131698

Etonkovidova closed subtask T390675: Suggested edits module homepage logger interaction data lacks a valid homepage_pageview_token as Resolved.Apr 10 2025, 10:13 PM
Etonkovidova reopened subtask T390675: Suggested edits module homepage logger interaction data lacks a valid homepage_pageview_token as Open.Apr 22 2025, 8:51 PM
Michael mentioned this in T388787: Remove now unused PHP config settings.Apr 23 2025, 8:42 AM
Etonkovidova closed subtask T390675: Suggested edits module homepage logger interaction data lacks a valid homepage_pageview_token as Resolved.May 2 2025, 6:31 PM
gerritbot added a comment.May 5 2025, 2:19 PM

Change #1131696 merged by jenkins-bot:

[operations/mediawiki-config@master] Growth: Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags

https://gerrit.wikimedia.org/r/1131696

Stashbot added a comment.May 5 2025, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-05T14:19:56Z] <kartik@deploy1003> Started scap sync-world: Backport for [[gerrit:1131696|Growth: Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags (T379566)]]

Stashbot added a comment.May 5 2025, 2:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-05T14:25:56Z] <kartik@deploy1003> cyndywikime, kartik: Backport for [[gerrit:1131696|Growth: Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags (T379566)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.May 5 2025, 2:32 PM
Stashbot added a comment.May 5 2025, 2:39 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-05T14:39:28Z] <kartik@deploy1003> Finished scap sync-world: Backport for [[gerrit:1131696|Growth: Remove GELevelingUpFeaturesEnabled and GEMentorDashboardEnabled feature flags (T379566)]] (duration: 19m 32s)

Sgs updated the task description. (Show Details)May 6 2025, 10:13 AM
Sgs moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.
DMburugu added subscribers: Sgs, DMburugu.May 8 2025, 2:03 PM

@Cyndymediawiksim and @Sgs These feature flags were non existent or only yielded a match in the cvn-infrastructure:

  • GEHelpPanelEnabled - The only code search match was found in the cvn-infrastructure
  • WelcomeSurveyEnabled - The only code search match was found in the cvn-infrastructure
  • GEHomepageEnabled - The only code search match was found in the cvn-infrastructure
  • GEHomepageLoggingEnabled - The only code search match was found in the cvn-infrastructure
  • GEConfirmEmailEnabled - No code search match was found anywhere
  • GELevelingUpFeaturesEnabled - No code search match was found on GrowthExperiments
  • GELevelingUpFeaturesEnabled - No code search match was found on mediawiki-config

This feature flag was still referenced in GrowthExperiments and mediawiki-config:

  • GEMentorDashboardEnabled - A code search match was found on GrowthExperiments
  • GEMentorDashboardEnabled - A code search match was found on mediawiki-config
Cyndymediawiksim added a comment.May 9 2025, 6:57 AM

Hey @DMburugu,

Thanks for checking!The presence of feature flags in the CVN infrastructure should not impact this task. The task scope focused on removing obsolete feature flags that are referenced in GrowthExperiments and mediawiki-config.

For GEMentorDashboardEnabled code search that you linked seems to link to GEMentorDashboardEnabledModules which appears to be a different feature flag.

DMburugu added a comment.EditedMay 13 2025, 8:26 AM

Yes you're right, I didn't see the rest of the match.

My review is updated to reflect this:

  • GEMentorDashboardEnabled - No code search match was found on GrowthExperiments
  • GEMentorDashboardEnabled - No code search match was found on mediawiki-config
Etonkovidova closed this task as Resolved.May 22 2025, 1:09 AM
Michael mentioned this in T332826: Remove GEHomepageEnabled config flag.Jul 4 2025, 11:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits