Page MenuHomePhabricator
Create Task
Maniphest T379568

Remove obsolete GENewcomerTasksGuidanceEnabled feature flag
Closed, ResolvedPublic
Actions

Description

This task is very similar to the task for removing other obsolete feature flags (T379566), except that GENewcomerTasksGuidanceEnabled exists not only in GrowthExperiments, but also in two strange "speed-tests" files in mediawiki-config:

This task exists to figure out what's up with those files and how to remove our obsolete config variable from them as well without breaking things.

Acceptance criteria:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove GENewcomerTasksGuidanceEnabled feature flagmediawiki/extensions/GrowthExperimentsmaster+16 -73
Regenerate speed-test snapshot without GENewcomerTasksGuidanceEnabledoperations/mediawiki-configmaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 11 2024, 3:47 PM
Michael moved this task from Inbox to Needs Discussion on the Growth-Team board.Nov 12 2024, 4:51 PM
Michael mentioned this in T380492: Remove `GEStructuredTaskRejectionReasonTextInputEnabled` config flag and associated custom text input for the "other"-option when rejecting a structured recommendation.Nov 21 2024, 3:40 PM
KStoller-WMF triaged this task as Medium priority.Apr 16 2025, 5:47 PM
KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
gerritbot added a comment.Apr 22 2025, 2:23 PM

Change #1138089 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GENewcomerTasksGuidanceEnabled feature flag

https://gerrit.wikimedia.org/r/1138089

gerritbot added a project: Patch-For-Review.Apr 22 2025, 2:23 PM
gerritbot added a comment.Apr 23 2025, 1:06 PM

Change #1138350 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[operations/mediawiki-config@master] Regenerate speed-test snapshot without GENewcomerTasksGuidanceEnabled

https://gerrit.wikimedia.org/r/1138350

Cyndymediawiksim claimed this task.Apr 28 2025, 9:19 AM
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.Apr 28 2025, 9:21 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Apr 29 2025, 4:43 PM
Sgs added subscribers: Krinkle, Sgs.Apr 30 2025, 11:12 AM

I tried to review the speed tests change but I have actually no clue how these work, run or need to be re-generated. From which environment are they supposed to be generated? Where is this outcome consumed?

ftr: I locally tried php tests/captureSpeedtest.php Oceanic.enwiki.1046871765 https://en.wikipedia.org/wiki/Oceanic_Airlines, the output was a bunch of added files and a modified index.html but not the same as in 1138350 Regenerate speed-test snapshot without GENewcomerTasksGuidanceEnabled, so I'm not sure how to review the patch.

@Krinkle, since you were the script creator, could you help us answer some of these questions? Thank you!

Sgs added a comment.Apr 30 2025, 11:25 AM

Reviewing I found GENewcomerTasksGuidanceRequiresOptIn which was introduced in T253794 for pre-enabling testing purposes. We probably should remove it along with GENewcomerTasksGuidanceEnabled as its only purpose was to modify the behavior of the global switch. cc @Cyndymediawiksim

Sgs moved this task from Code Review to Doing on the Growth-Team (Current Sprint) board.Apr 30 2025, 11:29 AM
gerritbot added a comment.May 5 2025, 11:44 AM

Change #1138350 abandoned by Cyndywikime:

[operations/mediawiki-config@master] Regenerate speed-test snapshot without GENewcomerTasksGuidanceEnabled

Reason:

Based upon Timo's review, we do not touch any live data, snapshots can stay as they are

https://gerrit.wikimedia.org/r/1138350

Sgs updated the task description. (Show Details)May 6 2025, 10:22 AM
Sgs moved this task from Doing to QA on the Growth-Team (Current Sprint) board.May 6 2025, 11:46 AM
gerritbot added a comment.May 6 2025, 12:05 PM

Change #1138089 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove GENewcomerTasksGuidanceEnabled feature flag

https://gerrit.wikimedia.org/r/1138089

Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 12:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 6 2025, 1:00 PM
Sgs raised the priority of this task from Medium to High.May 7 2025, 12:04 PM
Sgs renamed this task from Remove obsolete GENewcomerTasksGuidanceEnabled feature flag (incl. figure out how) to Remove obsolete GENewcomerTasksGuidanceEnabled feature flag.May 7 2025, 5:02 PM
DMburugu subscribed.EditedMay 8 2025, 1:49 PM

@Cyndymediawiksim and @Sgs I'm only seeing code search matches on the speedtest and cvn-infrastructure, other than that the second acceptance criteria has been met.

If these matches found don't mean anything to us the task can be marked as closed.

Cyndymediawiksim added a comment.May 9 2025, 6:59 AM

@DMburugu , these matches shouldn't affect the task.

KStoller-WMF subscribed.May 9 2025, 10:35 PM

Tested on en.wikipedia.beta, from desktop:

From an existing account that has Growth features enabled, I tested to ensure the (Newcomer guidance) Help panel works as expected and respects the associated Community Configuration settings.

✅ The Current Beta configuration settings were respected and worked as expected:

Namespaces where the help panel is available in reading mode

  • User
  • Wikipedia
  • Help

Namespaces to include in the help panel's free text search for help:

  • Wikipedia
  • Help

Also tested:
✅ Help panel displays within VE and Source Editor
✅ Help panel DOES NOT display within mainspace Read / article view.

DMburugu added a comment.May 13 2025, 8:20 AM

@Cyndymediawiksim Then the task description can be updated to indicate that the criteria has been met and we plan to close this after it's deployed to production.

Etonkovidova updated the task description. (Show Details)May 21 2025, 12:13 AM
Etonkovidova closed this task as Resolved.May 21 2025, 12:24 AM
Etonkovidova subscribed.
In T379568#10815143, @DMburugu wrote:

@Cyndymediawiksim Then the task description can be updated to indicate that the criteria has been met and we plan to close this after it's deployed to production.

Checked on wmf.2 and updated the task description.
I marked the followint as Done - two speed tests are still present, but they are not in the scope of this task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits