PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Reedy
	Nov 11 2024, 10:29 PM

Description

In T376276#10306963, Umherirrender wrote:

Running the sniff from T362014 against mediawiki/vendor (833e3acddb) shows many code in different packages

library	upstream task	our task	done?
`league/event`	https://github.com/thephpleague/event/commit/13e437ced2a31883f00f9e9edde7f00afb943e21 => v3.0.3; will need updated `league/oauth2-server`; see also T261462		❌
`league/oauth2-server`	https://github.com/thephpleague/oauth2-server/commit/9b99c22c64189da397fb5e5b41033ce679c6589d but introduce use of constructor property promotion from php8 => v9.1.0; see also T261462		❌
`league/uri-components`	https://github.com/thephpleague/uri-components/commit/63796b08e15f7845fdc11351a43928e538d141c5 needs 7.4.1, which requires PHP 8.1; see also T261462		❌
`league/uri-interfaces`	needs 7.4.1, which requires PHP 8.1; see also T261462		❌
`monolog/monolog`	Needs update to 3.8.0 https://github.com/Seldaek/monolog/pull/1903 https://github.com/Seldaek/monolog/releases/tag/3.8.0 (though our 2.9.3 version doesn't have the issues)		❌
`luggio/statsd-phpclient`		T326607: Future of liuggio/statsd-php-client?	❌

library	upstream task	our task	done?
`beberlei/assert`	Needs update to `3.3.3`		✅
`mck89/peast`	Needs update to `1.16.3`		✅
`psr/http-factory`	Needs update to `1.1.0`		✅
`data-values/common`	https://github.com/DataValues/Common/commit/06415a03d13e35ea471630ec6fa0f1f44cd45053 v1.2.0	T379481	✅
`data-values/geo`	https://github.com/DataValues/Geo/commit/518f36af29c40743d165d15ea5460647ea6d0cf9 v4.5.0	T379481	✅
`data-values/interfaces`	https://github.com/DataValues/Interfaces/commit/ae70d199a9851c7d1e93258d33376ee46477e049 v1.2.0	T379481	✅
`data-values/number`	https://github.com/wmde/Number/commit/356531a83b797e09a74677abe8a0df1ef708c685 v0.13.0	T379481	✅
`data-values/time`	https://github.com/wmde/Time/commit/7af710bd0b25cdefe09884e6fd8698a742849c5f v1.2.0	T379481	✅
`diff/diff`	https://github.com/wmde/Diff/commit/126283e5a111c974e37dd6352ff26678b7540308 v3.4.0	T379481	✅
`serialization/serialization`	https://github.com/wmde/Serialization/commit/85fff2f413f58d9c7ab80b27d17c7979b0d4ee77 v4.1.0	T379481	✅
`opis/json-schema`	The latest version seems okay for php8.4	T319054	✅
`ezimuel/ringphp`	https://github.com/ezimuel/ringphp/pull/13 v1.2.3		✅
`react/promise`	https://github.com/reactphp/promise/commit/57cafa9cd6b94ce8f31f8bc97ce6fb321f775041 blocked on `ezimuel/ringphp`, needs `1.3.0`		✅
`pear/net_url2`	https://github.com/pear/Net_URL2/commit/82f8273feb8afd4a602b1edcb54d0793bf635893 https://pear.php.net/bugs/bug.php?id=28649	T388273: Minify's dependency `pear/net_url2` triggers a PHPUnit test failure on PHP 8.4 in vendor	✅
`bacon/bacon-qr-code`	https://github.com/Bacon/BaconQrCode/commit/1b2647581d70b1bdd1d33e3ce950139eee339829 v3.0, needs PHP 8.1	T378424	✅
`endroid/qr-code`	https://github.com/endroid/qr-code/commit/61cc3ef6863936b58e0cbe63a44da79efe3c84cd v6.0, needs PHP 8.2	T378424	✅
`swaggest/json-diff`	https://github.com/swaggest/json-diff/pull/69, needs 3.12.1		✅
`firebase/php-jwt`	https://github.com/firebase/php-jwt/releases/tag/v6.10.2 needs PHP 8.0		✅
`maxmind/web-service-common`	fix at https://github.com/maxmind/web-service-common-php/commit/f33ce5bef4ba50b6c5d2cdd33e6ecf81e4af7908 in 0.10.0, needs PHP 8.1		✅
`elasticsearch/elasticsearch`	https://github.com/elastic/elasticsearch-php/pull/1415 => v8.16.0 / https://github.com/elastic/elasticsearch-php/pull/1417 => v7.17.3		✅
`ezimuel/guzzlestreams`	https://github.com/ezimuel/guzzlestreams/pull/3 => https://github.com/ezimuel/guzzlestreams/releases/tag/4.1.0		✅
`geoip2/geoip2`	fix at https://github.com/maxmind/GeoIP2-php/commit/67934d02c53197af26191359247d139308e5cf5a in 3.1.0, needs PHP 8.1 since 3.0.0	T380185	✅
`thecodingmachine/safe`	https://github.com/thecodingmachine/safe/issues/442 v3.0, needs PHP 8.1; blocked on WebAuthn	T363639 dropped this library	✅
`web-auth/webauthn-lib`	Fixed in https://github.com/web-auth/webauthn-framework/commit/5899d9e1696ca1ea96ac902608db6111716f1f7f v5.1.0, needs PHP 8.2	T363639	✅

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update ezimuel/*	mediawiki/vendor	master	+63 -47
Upgrading elasticsearch/elasticsearch (v7.17.1 => v7.17.3)	mediawiki/extensions/Elastica	REL1_43	+1 -1
Upgrading elasticsearch/elasticsearch (v7.17.1 => v7.17.3)	mediawiki/extensions/Elastica	REL1_44	+1 -1
Upgrading elasticsearch/elasticsearch (v7.17.1 => v7.17.3)	mediawiki/extensions/Elastica	master	+1 -1
Upgrading elasticsearch/elasticsearch (v7.17.1 => v7.17.3)	mediawiki/vendor	master	+116 -40
Upgrading maxmind*	mediawiki/vendor	master	+140 -99
Upgrading firebase/php-jwt (v6.10.0 => v6.11.1)	mediawiki/vendor	master	+134 -116

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
Open	None	T379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Resolved	Reedy	T378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Resolved	ArthurTaylor	T379481 [GENERAL] PHP 8.4 issues in WMDE/Wikidata libraries
Resolved	Reedy	T380185 Prepare for newer geoip2/geoip2 library
Resolved	Reedy	T388273 Minify's dependency `pear/net_url2` triggers a PHPUnit test failure on PHP 8.4 in vendor
		· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Reedy updated the task description. (Show Details)Nov 11 2024, 11:12 PM

Reedy added a project: PHP 8.4 support.Nov 14 2024, 2:44 AM

Reedy moved this task from Backlog to Other on the PHP 8.4 support board.

Reedy updated the task description. (Show Details)Nov 14 2024, 3:09 AM

Reedy updated the task description. (Show Details)Nov 18 2024, 3:20 PM

Reedy updated the task description. (Show Details)Nov 18 2024, 3:27 PM

Reedy updated the task description. (Show Details)Nov 18 2024, 3:31 PM

Reedy updated the task description. (Show Details)

Reedy mentioned this in T380185: Prepare for newer geoip2/geoip2 library.Nov 18 2024, 3:34 PM

Reedy updated the task description. (Show Details)

Reedy added a subtask: T380185: Prepare for newer geoip2/geoip2 library.Nov 18 2024, 3:38 PM

Reedy updated the task description. (Show Details)

Reedy updated the task description. (Show Details)Nov 25 2024, 2:51 PM

Umherirrender updated the task description. (Show Details)Dec 13 2024, 9:40 PM

Reedy updated the task description. (Show Details)Dec 13 2024, 10:19 PM

Reedy updated the task description. (Show Details)

Reedy updated the task description. (Show Details)Dec 13 2024, 10:23 PM

Reedy updated the task description. (Show Details)

Reedy updated the task description. (Show Details)Dec 13 2024, 10:26 PM

Many of the WMDE related ones I've marked as unreleased... They're released, but not integrated into vendor yet... So I'm gonna leave it as is, next update should be that they're fixed

Reedy updated the task description. (Show Details)Jan 2 2025, 12:01 AM

Reedy updated the task description. (Show Details)Jan 2 2025, 12:08 AM

Reedy updated the task description. (Show Details)Jan 2 2025, 12:11 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 10 2025, 1:50 PM

Lucas_Werkmeister_WMDE closed subtask T379481: [GENERAL] PHP 8.4 issues in WMDE/Wikidata libraries as Resolved.

Reedy mentioned this in T378424: PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs.Jan 25 2025, 12:15 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 19 2025, 4:20 PM

Umherirrender unsubscribed.Feb 25 2025, 5:29 PM

Umherirrender mentioned this in T387408: PHP Fatal error: Uncaught Error: Class "MediaWiki\HookContainer\HookRunner" not found.Feb 28 2025, 10:35 PM

For an overview of the files/packages for the moment see https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1123722 (running the sniff against mediawiki/vendor)

Reedy updated the task description. (Show Details)Feb 28 2025, 10:59 PM

Reedy added a subscriber: Umherirrender.

Reedy updated the task description. (Show Details)Feb 28 2025, 11:01 PM

Reedy updated the task description. (Show Details)

Umherirrender mentioned this in T388273: Minify's dependency `pear/net_url2` triggers a PHPUnit test failure on PHP 8.4 in vendor.Mar 7 2025, 9:53 PM

Reedy updated the task description. (Show Details)Mar 7 2025, 10:09 PM

Reedy updated the task description. (Show Details)Mar 7 2025, 10:14 PM

Reedy updated the task description. (Show Details)

https://gerrit.wikimedia.org/r/1125528
https://gerrit.wikimedia.org/r/1125531
https://gerrit.wikimedia.org/r/1125522

^ These three will fix ezimuel/ringphp and react/promise updates...

Reedy updated the task description. (Show Details)Mar 7 2025, 10:24 PM

Umherirrender updated the task description. (Show Details)Mar 7 2025, 10:25 PM