Page MenuHomePhabricator

attachAccount.php should not use "login" method
Closed, ResolvedPublicFeature

Description

attachAccount.php uses the login attachment method (the $method parameter to CentralAuthUser::attach()). That's for newly autocreated accounts which start as attached, which is obviously not the case for accounts the script is used for. It should probably use admin or maybe a dedicated new method.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Note:
(1) Currently lu_attached_method is enum and we need schema change to introduce new method.
(2) Also another field lu_attachment_method is added but currently unused (see T304015: Change CentralAuth database field localuser.lu_attached_method to not be an enum)
(3) "login" attachment method is currently (mis)used for other things, see T201477 and T302771.

In T304015#7808836 I propose to remove the "attachment method" concept completely.

Tgr renamed this task from attachAccount.php should not use "new" method to attachAccount.php should not use "login" method.Nov 12 2024, 1:57 PM

In previous weeks many Wikitech accounts are attached to SUL, and they all used "login" method.

Change #1123328 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] attachAccount: Set attachement method to 'admin'

https://gerrit.wikimedia.org/r/1123328

Change #1123328 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] attachAccount: Set attachment method to 'admin'

https://gerrit.wikimedia.org/r/1123328

matmarex assigned this task to Zabe.
matmarex subscribed.