| kostajh | |
| Nov 12 2024, 1:17 PM |
| F57773187: image.png | |
| Dec 3 2024, 5:39 AM |
| F57696078: image.png | |
| Nov 12 2024, 1:17 PM |
After selecting an "immediate threat of physical harm" type of incident, you should be taken to this screen:
Acceptance criteria:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Madalina | T374105 Incident Reporting System - MVP | |||
| Resolved | Madalina | T374108 [Epic] Incident Submission for Emergencies | |||
| Resolved | Madalina | T379063 [Epic] Implement updated IRS emergency flow | |||
| Resolved | • mszabo | T379620 Create the "Report an immediate threat of harm to emergency team" screen |
Change #1091219 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):
[mediawiki/extensions/ReportIncident@master] dialog: Compute title based on current step
Change #1091219 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@master] dialog: Compute title based on current step
Change #1091276 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):
[mediawiki/extensions/ReportIncident@master] dialog: Introduce a CharacterLimitedTextArea component
Change #1092053 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):
[mediawiki/extensions/ReportIncident@master] dialog: Factor out ReportImmediateHarmStep component
Change #1091276 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@master] dialog: Introduce a CharacterLimitedTextArea component
Change #1092053 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@master] dialog: Factor out ReportImmediateHarmStep component
@mszabo
During testing I did notice 3 items that I wanted to run by you...
1st item:
When I use the Tools menu - Report option, and then reach the Report an immediate threat of harm to emergency team screen, if I don't input a user to report, and then click Submit Report button, its allowing me to Submit the report without displaying an error message regarding the entry of the user to report...
Is this the expected behavior, or should it display an error message notifying the user to input the name they are reporting?
2nd item:
This is a minor punctuation issue, the following text is missing a comma after the word address:
A link to the incident you are reporting (including the reported user) and your own username and email address will be shared privately with the Wikimedia Foundation emergency team.
3rd item:
The Acceptance Criteria in the ticket Description says:
Clicking the submit button takes the user to T379242: Create submission confirmation screen
That ticket number that its referencing for that AC is actually the Submission Confirmation screen for the Non-Emergency flow, so I figured this specific criteria was meant to say that the user should be taken to the Submission Confirmation screen for the Emergency flow instead of the Submission Confirmation screen for the Non-Emergency flow, so I went ahead and verified that specific AC did take the user to the correct Submission Confirmation screen for the Emergency flow.
Expected behavior. See T381119: Reporting deleted user results in "You must provide an existing username to report"
2nd item:
This is a minor punctuation issue, the following text is missing a comma after the word address:A link to the incident you are reporting (including the reported user) and your own username and email address will be shared privately with the Wikimedia Foundation emergency team.
Figma is up to date to not have the comma, see also this thread.
3rd item:
The Acceptance Criteria in the ticket Description says:Clicking the submit button takes the user to T379242: Create submission confirmation screen
That ticket number that its referencing for that AC is actually the Submission Confirmation screen for the Non-Emergency flow, so I figured this specific criteria was meant to say that the user should be taken to the Submission Confirmation screen for the Emergency flow instead of the Submission Confirmation screen for the Non-Emergency flow, so I went ahead and verified that specific AC did take the user to the correct Submission Confirmation screen for the Emergency flow.
That sounds right. Given the above, I'll resolve this task.