Unable to generate user impact for user in RefreshUserImpactJob.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Michael
	Nov 12 2024, 7:27 PM

Description

Error

mwversion: 1.44.0-wmf.1
reqId: 42a71e80a3a2f9b77bce2976
Find reqId in Logstash

normalized_message

Unable to generate user impact for user in RefreshUserImpactJob.

Impact

Logspam. A background job was attempting to generate user impact data for Temporary accounts, which is not possible (hence the errors logged). Impact data for Temporary accounts is not queried by anything, so nothing was lost.

Notes

The codepath that is triggered here was added in Makeshift deduplication for RefreshUserImpactJob in Nov 2022 for T322706

Seems to be new:

It does not seem to have cleanly started with a Train:

, and we haven't worked/backported anything in the vicinity of that recently, as far as I remember.

Details

Request URL: https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	refreshUserImpactData: Do not schedule updates for Temporary accounts	mediawiki/extensions/GrowthExperiments	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned Here: T322706: User impact API: Maintenance scripts should defer work to the job queue

Event Timeline

Michael created this task.Nov 12 2024, 7:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2024, 7:27 PM

KStoller-WMF subscribed.Nov 13 2024, 5:15 PM

Happening, because something tries to compute user impact data for Temporary accounts. That is not supposed to happen. I'll fix that.

Michael added a project: Temporary accounts.Nov 15 2024, 10:31 AM

Change #1091624 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refreshUserImpactData: Do not schedule updates for Temporary accounts

https://gerrit.wikimedia.org/r/1091624

gerritbot added a project: Patch-For-Review.Nov 15 2024, 11:21 AM

Urbanecm_WMF triaged this task as Medium priority.Nov 15 2024, 11:21 AM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Urbanecm_WMF updated the task description. (Show Details)Nov 15 2024, 11:25 AM

Urbanecm_WMF updated the task description. (Show Details)

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Nov 15 2024, 4:39 PM

Change #1091624 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refreshUserImpactData: Do not schedule updates for Temporary accounts

https://gerrit.wikimedia.org/r/1091624

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Nov 15 2024, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2024, 5:30 PM

Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Current Sprint) board.Nov 18 2024, 5:04 PM

Checked - no errors reported for mwversion: 1.44.0-wmf.4 - the logstash link

Unable to generate user impact for user in RefreshUserImpactJob.Closed, ResolvedPublicPRODUCTION ERRORActions