[XS] Top portion of settings screen does not change after YIR and changing theme
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	ABorbaWMF
	Nov 13 2024, 4:28 PM

Description

Steps to replicate the issue (include links if applicable):

Run YIR
Navigate to settings and change the theme
View the setting screen

What happens?:
The top portion of the screen, Settings and Close Icon (x), does not change to the new theme. When switching from a light theme to a dark theme, or vice versa, the top portion is unreadable.

What should have happened instead?:
The theme should change the whole screen

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Tested on 7.6.2 (4449) on both iPhone and iPad
Other information (browser name/version, screenshots, etc.):
Note - I have not been able to reproduce this without running YIR in between theme changes.

Engineering Notes

It may have to do with this UIToolbar.appearance() update. Note changing the appearance class in this manner will customize all app toolbars, not just YiR.

Related Objects

Mentioned In: T379979: [M] Fix Sepia bottom toolbar bug
T379643: [BUG] Settings navigation bar incorrect color on dark mode

Event Timeline

ABorbaWMF created this task.Nov 13 2024, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2024, 4:28 PM

HNordeenWMF triaged this task as Low priority.Nov 13 2024, 4:45 PM

HNordeenWMF raised the priority of this task from Low to Medium.

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener updated the task description. (Show Details)Nov 13 2024, 6:31 PM

Tsevener mentioned this in T379643: [BUG] Settings navigation bar incorrect color on dark mode.

Tsevener renamed this task from Top portion of settings screen does not change after YIR and changing theme to [M] Top portion of settings screen does not change after YIR and changing theme.Nov 14 2024, 3:56 PM

HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 14 2024, 4:44 PM

HNordeenWMF raised the priority of this task from Medium to High.Nov 14 2024, 8:55 PM

HNordeenWMF moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Note: this also looks like it's affecting the Article view bottom tool bar, Talk page bottom toolbar, header when you create a new talk page message, Diff view bottom toolbar.

Tsevener renamed this task from [M] Top portion of settings screen does not change after YIR and changing theme to [XS] Top portion of settings screen does not change after YIR and changing theme.Nov 14 2024, 10:02 PM

Tsevener claimed this task.

Tsevener moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 14 2024, 10:10 PM

Tsevener mentioned this in T379979: [M] Fix Sepia bottom toolbar bug.Nov 14 2024, 10:15 PM

https://github.com/wikimedia/wikipedia-ios/pull/5075

l-olson1214 closed https://github.com/wikimedia/wikipedia-ios/pull/5075

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 15 2024, 7:36 PM

Tsevener removed Tsevener as the assignee of this task.Nov 15 2024, 8:43 PM

Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener subscribed.

Looking fixed to me