Page MenuHomePhabricator

Introduce a generic mechanism to dismiss Edit Checks
Closed, ResolvedPublic

Description

In T374066, @zoe built a proof of concept for an Edit Check that prompts people to add a caption when they attempt to add a new image that lacks one.

In doing the above, we discovered that it could be useful to introduce a generic mechanism for dismissing an Edit Check. Where the "generic mechanism" here refers to a mechanism that would enable the software to store the following components for any arbitrary Edit Check:

  • The content range the Check at-hand is relevant to
  • The state of the content within said "content range"
  • The Check(s) relevant to said "content range"
  • Whether someone has decided to decline modifying the "content range" in the way(s) the Edit Check they are being presented has invited them to

References

Event Timeline

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.
ppelberg moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the EditCheck board.

We talked about this during the prototype development -- it's why we settled on the multicheck prototype only doing a single pass of check-generation for the pre-save checks, rather than regenerating the list after each check is acted on.

Change #1092826 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Allow checks to be dismissed by fragment or ID

https://gerrit.wikimedia.org/r/1092826

Change #1092826 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Allow checks to be dismissed by fragment or ID

https://gerrit.wikimedia.org/r/1092826

Esanders added a project: Skipped QA.

This functionality will be used by future checks so can be QA'd then.

This functionality will be used by future checks so can be QA'd then.

@Esanders: can you please describe the steps Editing QA will need to take in order to verify this functionality is working as expected?

VPuffetMichel added a project: OKR-Work.

Closing, will be tested in different later tasks and will be described there.