"(no username available)" shown twice for hidden revisions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Nov 14 2024, 9:23 AM

Description

What is the problem?

If a revision has its editor hidden, the entry in Special:GlobalContributions will show:

(no username available) ((no username available))

Steps to reproduce problem

Go to Special:GlobalContributions/<ip> for an <ip> you know has temporary account edits on the current wiki
On one of the entries, click "(change visibility)"
Check "Editor's username/IP address" and submit
Refresh Special:GlobalContributions/<ip>

Expected behaviour: The entry you just hid has only one "(no username available)".
Observed behaviour: "(no username available)" is shown twice.

Environment

Wiki(s): local docker CheckUser 2.5 (f4155ae) 17:43, 13 November 2024.

Screenshots

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
contributions: Move formatUserLink() logic into a formatter service	mediawiki/core	master	+392 -20
globalcontributions: Move formatUserLink() into a formatter service	mediawiki/extensions/CheckUser	master	+665 -214
globalcontributions: Don't show "no username available" twice in log entries	mediawiki/extensions/CheckUser	master	+34 -25

Customize query in gerrit

Related Objects

Mentioned Here: rECHUf4155aeaa89c: Merge "Hide IP reveal tool on CheckUserLog, ActiveUsers, and ListUsers"

Event Timeline

dom_walden created this task.Nov 14 2024, 9:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2024, 9:23 AM

From memory, this may be an upstream bug with Special:Contributions. We should look into that, however, because I may be wrong.

Tchanders moved this task from Backlog to Triaged on the CheckUser-GlobalContributions board.Mar 14 2025, 1:34 PM

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)); removed Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)).Mar 24 2025, 2:19 PM

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)); removed Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)).Apr 14 2025, 2:54 PM

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)); removed Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).May 5 2025, 6:50 AM

kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 5 2025, 7:02 AM

@dom_walden is this still reproducible?

STran moved this task from Triaged to Ready on the CheckUser-GlobalContributions board.May 6 2025, 9:36 AM

hector.arroyo changed the task status from Open to In Progress.May 14 2025, 10:55 AM

hector.arroyo claimed this task.

hector.arroyo moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.

Change #1145908 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] globalcontributions: Don't show "no username available" twice in log entries

https://gerrit.wikimedia.org/r/1145908

Change #1145909 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/core@master] contributions: Don't show "no username available" twice in log entries

https://gerrit.wikimedia.org/r/1145909

Change #1145908 merged by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] globalcontributions: Don't show "no username available" twice in log entries

https://gerrit.wikimedia.org/r/1145908

Dreamy_Jazz moved this task from Ready to In Progress on the CheckUser-GlobalContributions board.May 14 2025, 4:53 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 5:00 PM

kostajh moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 14 2025, 5:35 PM

Change #1146024 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] globalcontributions: Move formatUserLink() logic into a formatter service

https://gerrit.wikimedia.org/r/1146024

hector.arroyo moved this task from Needs QA to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 19 2025, 12:57 PM

I've submitted two additional patches to clean up the code a little bit and update unit tests that are now ready for review:

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)); removed Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)).May 25 2025, 6:58 PM

kostajh moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.

hector.arroyo moved this task from Inbox to Engineering on the Trust and Safety Product Team board.May 30 2025, 9:11 AM

The two additional patches introduce technical changes but, from a functional point of view, this was fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1145908, which was merged two weeks ago. Since the fix was already merged, I'm setting the new patches as Drafts so the fix itself can be moved to QA on its own.

hector.arroyo moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.May 30 2025, 1:38 PM

The new code changes have been verified and are functioning as expected (Special:GlobalContributions/<ip>: The entry that's hidden shows '(no username available)' only once instead of twice).

Tchanders closed this task as Resolved.Jun 9 2025, 8:55 AM

Change #1146024 abandoned by Harroyo-wmf:

[mediawiki/extensions/CheckUser@master] globalcontributions: Move formatUserLink() into a formatter service

https://gerrit.wikimedia.org/r/1146024

Change #1145909 abandoned by Harroyo-wmf:

[mediawiki/core@master] contributions: Move formatUserLink() logic into a formatter service