Page MenuHomePhabricator
Create Task
Maniphest T379918

ReplyTool/Topic sub issues with username '0'
Closed, ResolvedPublicBUG REPORT
Actions

Description

While username '0' is rare, it is a valid MediaWiki username, so it should mostly be usable where possible

  1. Users cannot subscribe to topics created by user '0'
  2. Users cannot reply to the topics too
  3. The user gets duplicate signatures when using visual edit

Details

SubjectRepoBranchLines +/-
commentparser: Allow signature of user '0' to be detectedmediawiki/extensions/DiscussionToolsREL1_43+3 -3
commentparser: Allow signature of user '0' to be detectedmediawiki/extensions/DiscussionToolsmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.Nov 14 2024, 1:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2024, 1:58 PM
Ammarpad mentioned this in T368699: DiscussionTools creating duplicate signatures on user talk pages.Nov 14 2024, 2:01 PM
gerritbot added a comment.Fri, Nov 15, 6:03 PM

Change #1091786 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@master] commentparser: Allow signature of user '0' to be detected

https://gerrit.wikimedia.org/r/1091786

gerritbot added a project: Patch-For-Review.Fri, Nov 15, 6:03 PM
gerritbot added a comment.Mon, Nov 18, 6:54 PM

Change #1091786 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] commentparser: Allow signature of user '0' to be detected

https://gerrit.wikimedia.org/r/1091786

gerritbot added a comment.Mon, Nov 18, 6:55 PM

Change #1092317 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@REL1_43] commentparser: Allow signature of user '0' to be detected

https://gerrit.wikimedia.org/r/1092317

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Mon, Nov 18, 7:00 PM
gerritbot added a comment.Mon, Nov 18, 7:09 PM

Change #1092317 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_43] commentparser: Allow signature of user '0' to be detected

https://gerrit.wikimedia.org/r/1092317

Maintenance_bot removed a project: Patch-For-Review.Mon, Nov 18, 7:30 PM
matmarex closed this task as Resolved.Mon, Nov 18, 7:56 PM
matmarex assigned this task to Ammarpad.
matmarex subscribed.

Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits