Use WeakMap instead of an array in RestrictedEntityLookupFactory
Closed, ResolvedPublic
Actions

Description

1091251: Refactor: Use WeakMap in RestrictedEntityLookupFactory WeakMap implementation can be merged when the support for PHP 7.4 is dropped. The original array implementation will then be removed.

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		seanleong-WMDE	T379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
Resolved		Jdforrester-WMF	T328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
Resolved		Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved		tstarling	T292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
Resolved		Jdforrester-WMF	T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved		Jdforrester-WMF	T319065 All Wikimedia production extensions and skins must support PHP 8.1
Resolved		tstarling	T314212 str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved		Reedy	T311448 Echo PHP 8.1 support
Resolved	BUG REPORT	tstarling	T289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
Resolved		tstarling	T320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
Resolved		Daimona	T311451 Re-enable PHP 8.1 CI on css-sanitizer
Resolved		Daimona	T311452 Taint Check Plugin release
Resolved		None	T307506 Address PHP 8.1 job failures on various PHP libs
Resolved		Jdforrester-WMF	T311450 Re-enable PHP 8.1 CI on RemexHTML
Resolved	BUG REPORT	None	T308406 RemexHtml should support PHP 8.1
Resolved		tstarling	T307630 mediawiki/libs/RemexHtml phan issues under 8.1
Resolved		Jdforrester-WMF	T311463 Re-enable PHP 8.1 CI on Zest
Resolved		ssastry	T307632 mediawiki/libs/Zest phan issues under 8.1
Resolved		kostajh	T321600 GrowthExperiments PHP 8.1 support
Resolved		kostajh	T321691 StructuredDiscussions support for PHP 8.1
Resolved		thiemowmde	T321692 FileImporter support for PHP 8.1
Resolved		tstarling	T322098 GeoData support for PHP 8.1
Resolved		tstarling	T322099 TwoColConflict support for PHP 8.1
Resolved	BUG REPORT	Lucas_Werkmeister_WMDE	T319219 Wikibase gives deprecated warnings on php 8.1
Resolved		hoo	T301249 Handle deprecation of Serializable interface in Wikibase
Resolved		hoo	T305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
Resolved		Jdforrester-WMF	T322233 PageViewInfo support for PHP 8.1
Resolved		thiemowmde	T322408 CirrusSearch support for PHP 8.1
Resolved		kostajh	T322838 PageTriage PHP 8.1 support
Resolved		Umherirrender	T323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
Resolved	PRODUCTION ERROR	• brooke	T289189 getid3: PHP Warning: Division by zero
Resolved		TheresNoTime	T332356 function strftime() is deprecated in php 8.1 used by Calendar extension
Resolved		tstarling	T322278 MediaWiki core should pass Phan on PHP 8.1
Resolved		Jdforrester-WMF	T320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 instead of PHP 7.4
Resolved		• larissagaulia	T321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
Resolved		JMeybohm	T345561 Upgrade the MediaWiki servers to ICU 67
Resolved		MoritzMuehlenhoff	T350767 Rebuild PHP 7.4 packages for Bullseye
Resolved		None	T373752 Build php-uuid package, and add to WMF production and CI
Duplicate		None	T378043 Route requests with PHP_ENGINE=8.1 cookie to "next" deployment via ATS plugin
Resolved		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Reedy	T379834 PHP Deprecated: Automatic conversion of false to array is deprecated
Resolved	PRODUCTION ERROR	None	T384851 PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
Resolved	PRODUCTION ERROR	• mszabo	T384853 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	• mszabo	T384854 PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	• mszabo	T384858 PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	None	T384867 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T384879 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	• mszabo	T384906 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	None	T384963 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385028 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385061 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385170 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385169 PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	hashar	T385143 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T384694 TypeError: Argument 1 passed to MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref() must be of the type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php on l
Resolved	PRODUCTION ERROR	Reedy	T385201 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	thiemowmde	T385268 ArgumentCountError: array_merge() does not accept unknown named parameters
Resolved	PRODUCTION ERROR	Reedy	T385267 PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385269 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385331 PHP Deprecated: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Tacsipacsi	T385332 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385333 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385335 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T385452 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385460 PHP Deprecated: Brick\Math\BigInteger implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)
Resolved	PRODUCTION ERROR	dcausse	T385519 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	• mszabo	T385567 PHP Warning: Undefined array key 1 in ParsoidRenderID
Resolved	PRODUCTION ERROR	• mszabo	T385568 InvalidArgumentException: Bad key: -1" OR 2+583-583-1=0+0+0+1 --
Resolved	PRODUCTION ERROR	Reedy	T385588 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T385758 PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T385762 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T385763 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	jijiki	T385395 503 error when edit large size pages on PHP 8.1
Resolved		Scott_French	T386006 Update PCRE in PHP 8.1 images to PCRE 10.39 or newer
Resolved	PRODUCTION ERROR	ABreault-WMF	T384738 TypeError: preg_match() expects parameter 2 to be string, null given
Resolved	PRODUCTION ERROR	daniel	T387397 PHP Warning: Attempt to read property "text" on null
Resolved	PRODUCTION ERROR	Reedy	T387489 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388069 PHP Deprecated: Implicit conversion from float 143204.63041730312 to int loses precision
Resolved	PRODUCTION ERROR	Reedy	T388073 PHP Deprecated: Automatic conversion of false to array is deprecated
Resolved	PRODUCTION ERROR	ihurbain	T388160 TypeError: array_map(): Argument #2 ($array) must be of type array, string given
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388255 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388317 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388322 PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388339 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388355 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388464 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via ImageMap/InputBox)
Resolved	PRODUCTION ERROR	Reedy	T388466 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via FeaturedFeeds)
Resolved	PRODUCTION ERROR	Reedy	T388468 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via CentralNoticeCampaignLogPager)
Resolved	PRODUCTION ERROR	Reedy	T388469 PHP Deprecated: Automatic conversion of false to array is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388474 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388728 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Duplicate	PRODUCTION ERROR	None	T388729 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388812 PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T388814 PHP Warning: Undefined array key "view"
Resolved	PRODUCTION ERROR	Reedy	T388820 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388821 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
Duplicate	PRODUCTION ERROR	None	T388822 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T388900 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388924 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved	PRODUCTION ERROR	Paladox	T388944 PHP Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T389019 Argument #2 must be of type string, array given in /srv/mediawiki/docroot/wwwportal/w/search-redirect.php
Resolved	BUG REPORT	Wargo	T391297 www.wiktionary.org and other portals are redirecting searches to wikipedia
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T389020 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via CampaignLog)
Resolved	BUG REPORT	Scott_French	T389243 Update Excimer to 1.2.3 in production
Resolved	PRODUCTION ERROR	Reedy	T389261 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
Resolved	PRODUCTION ERROR	Reedy	T389515 PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used
Resolved	PRODUCTION ERROR	ssastry	T389642 PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$dsr
Resolved	PRODUCTION ERROR	Reedy	T388074 PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T391595 RSSParser: PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T391867 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T391871 PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
Resolved	PRODUCTION ERROR	Umherirrender	T391874 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
Resolved		Ladsgroup	T393879 PHP Deprecated: Implicit conversion from float 41.45954849253939 to int loses precision
Resolved	PRODUCTION ERROR	Umherirrender	T396591 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Resolved	Feature	• bd808	T378752 Install PHP 8.1 on deployment-prep bullseye MediaWiki instances
Resolved		Scott_French	T383845 MediaWiki on PHP 8.1 production traffic ramp-up
Resolved		Scott_French	T377042 Support cookie-driven fractional migration to PHP 8.1 deployments of mw-web and mw-api-ext
Resolved		Scott_French	T377040 Turn up PHP 8.1-flavored k8s deployments for all MediaWiki services
Resolved		Krinkle	T377987 Prepare sticky cookie for gradual PHP 8.1 rollout
Resolved		MSantos	T379986 Testing and verification of MediaWiki on PHP 8.1 in mwdebug-next
Resolved		• Tgr	T383633 Test MediaWiki authentication on PHP 8.1 in mwdebug-next
Resolved		Scott_French	T372605 Extend x-wikimedia-debug-routing.lua to support PHP 8.1 mw-debug deployment
Resolved		Scott_French	T372604 Turn up PHP 8.1-flavored mw-debug k8s deployment
Resolved		dduvall	T370934 Build and publish multiple MediaWiki production images for a given set of PHP versions
Resolved		Clement_Goubert	T376895 mw-debug-repl fails with `container mediawiki-pinkunicorn-app is not valid for pod mw-debug.codfw.next-5d785576b4-sq6dv`
Resolved		Scott_French	T372602 Prepare PHP 8.1 production images
Resolved		Scott_French	T372507 Prepare WMF PHP 8.1 packages for Bullseye
Resolved		Scott_French	T372603 Regenerate UcfirstOverrides.php for PHP 7.4 -> 8.1 transition
Resolved		Scott_French	T384532 Align mw-on-k8s alerts with PHP 8.1 migration
Resolved		ori	T385199 Gather PHP 8.1 profiling data
Resolved		Clement_Goubert	T387916 Migrate mw-cron to PHP 8.1
Resolved		Scott_French	T387917 Migrate mw-script to PHP 8.1
In Progress		Scott_French	T388799 php-wmerrors rsyslog rule selects on php7 only
Resolved		Scott_French	T380485 Transition parsoidtest1001 to PHP 8.1
Resolved		Scott_French	T390225 Migrate scap's maintenance script invocations to PHP 8.1
Resolved		Scott_French	T391057 Turn down MediaWiki image builds for PHP 7.4
Resolved		Scott_French	T392938 Remove PHP 7.4 from deployment hosts
Resolved		Scott_French	T394556 Clean up UcfirstOverrides.php following PHP 7.4 -> 8.1 transition
Resolved		Scott_French	T396903 Rename pages, images, and users to reflect migration to PHP 8.1 (Unicode 14) title-casing behavior
Resolved		Jdforrester-WMF	T359868 Drop PHP 7.4 and 8.0 support from MediaWiki 1.42; require PHP 8.1+

Event Timeline

seanleong-WMDE created this task.Nov 14 2024, 4:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2024, 4:05 PM

Lucas_Werkmeister_WMDE added a subtask: T358666: Drop PHP 8.1 support from MediaWiki.Nov 14 2024, 4:18 PM

Lucas_Werkmeister_WMDE added projects: Wikidata, MediaWiki-extensions-Wikibase-Client.

@Lucas_Werkmeister_WMDE – did you mean to block on dropping 8.1? FWICS WeakMap is available from PHP 8.0, so this should nominally be blocked on T319432 instead?

Sorry, I mixed that up – T328921: Drop PHP 7.4 and PHP 8.0 support from MediaWiki is probably the right task?

In T379930#10323167, @Lucas_Werkmeister_WMDE wrote:

Sorry, I mixed that up – T328921: Drop PHP 7.4 and PHP 8.0 support from MediaWiki is probably the right task?

Yup - just wanted to make sure that I wasn't missing something. :-) Phabricator is quite the thicket of gnarly tasks in this area. :-(

Jdforrester-WMF edited subtasks, added: T328921: Drop PHP 7.4 and PHP 8.0 support from MediaWiki; removed: T358666: Drop PHP 8.1 support from MediaWiki.Nov 14 2024, 4:39 PM

WMDE-leszek subscribed.Nov 14 2024, 5:24 PM

Tacsipacsi subscribed.Nov 14 2024, 9:42 PM

seanleong-WMDE added a project: Wikidata Integration in Wikimedia projects.Nov 15 2024, 10:04 AM

• WMDECyn moved this task from Backlog to Stalled / Waiting on the Wikidata Integration in Wikimedia projects board.Nov 15 2024, 12:02 PM

Jdforrester-WMF closed subtask T328921: Drop PHP 7.4 and PHP 8.0 support from MediaWiki as Resolved.Jun 6 2025, 6:25 PM

seanleong-WMDE closed this task as Resolved.Jul 1 2025, 7:45 AM

seanleong-WMDE claimed this task.

seanleong-WMDE moved this task from Stalled / Waiting to Kanban Board on the Wikidata Integration in Wikimedia projects board.

seanleong-WMDE edited projects, added Wikidata Integration in Wikimedia projects (Kanban Board); removed Wikidata Integration in Wikimedia projects.

seanleong-WMDE moved this task from In Progress to Done ( wit. set to "resolved" after prod / comm / ac testing) on the Wikidata Integration in Wikimedia projects (Kanban Board) board.